Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: sort agent/list-directory output#17218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/sort-agent-list-directory
Apr 3, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 2, 2025
edited
Loading

This sorts thecontents list alphabetically, but with directories before everything else.
This is purely for UX on the Coder Desktop side, where the user only really cares about directories, and files are just for providing context in the file picker.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 2, 2025 11:35
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR refines the output of the /list-directory agent command by sorting the contents list alphabetically with directories prioritized for an improved UX on the Coder Desktop interface.

  • Updated the sorting logic in agent/ls.go to ensure directories appear first, followed by files in alphabetical order.
  • Modified the test in agent/ls_internal_test.go to validate the new order using require.Equal.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
agent/ls_internal_test.goUpdated test expectations to check explicit sorted output.
agent/ls.goIntroduced a sorting function with directories prioritized.

ethanndickson reacted with hooray emoji
@ethanndicksonethanndickson merged commit998724d intomainApr 3, 2025
38 checks passed
@ethanndicksonethanndickson deleted the ethan/sort-agent-list-directory branchApril 3, 2025 01:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp