Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: deprecate ResourceSystem#17217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/resource-system
Apr 2, 2025
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedApr 2, 2025•
edited
Loading

DeprecatesResourceSystem. It's a large collection of unrelated things, and violates the principle of least privilege because to get access to low-security stuff like various statistics, you also get access to serious-security stuff like crypto keys.

We should eventually break it up and remove it, but the least we can do for now is not make the problem worse.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtisforce-pushed thespike/resource-system branch 7 times, most recently from398c07d to7e6e26cCompareApril 2, 2025 09:06
@spikecurtisspikecurtis requested a review fromEmyrkApril 2, 2025 09:07
@spikecurtisspikecurtis changed the titlechore: deprecate and lint for ResourceSystemchore: deprecate ResourceSystemApr 2, 2025
@spikecurtisspikecurtis marked this pull request as ready for reviewApril 2, 2025 09:09
@spikecurtisGraphite App
Copy link
ContributorAuthor

I initially added a ruleguard rule about it, but it's used so widely that the list of exceptions would be unbearably long. Hopefully the deprecation warning in IDEs will ward people off.

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

I am sure the list is quite large. Even enumerating the list to start fixing things sounds like a large task.

@spikecurtisspikecurtis merged commit83d7147 intomainApr 2, 2025
27 checks passed
@spikecurtisspikecurtis deleted the spike/resource-system branchApril 2, 2025 15:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp