Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(cli): support opening devcontainers in vscode#17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 9 commits intomainfromdm-open-devcontainer-cli
Apr 3, 2025
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
chore: run test on linux only
  • Loading branch information
@DanielleMaywood
DanielleMaywood committedApr 3, 2025
commit9cc49f825700844fa88779f46fb1237e34121872
2 changes: 0 additions & 2 deletionscli/open.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -136,8 +136,6 @@ func (r *RootCmd) openVSCode() *serpent.Command {
if !ok {
return xerrors.New("container missing volume for `devcontainer.local_folder`")
}

directory = filepath.FromSlash(directory)
}

break
Expand Down
8 changes: 8 additions & 0 deletionscli/open_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -293,6 +293,10 @@ func TestOpenVSCode_NoAgentDirectory(t *testing.T) {
func TestOpenVSCodeDevContainer(t *testing.T) {
t.Parallel()

if runtime.GOOS != "linux" {
t.Skip("DevContainers are only supported for agents on Linux")
}

agentName := "agent1"
agentDir, err := filepath.Abs(filepath.FromSlash("/tmp"))
require.NoError(t, err)
Expand DownExpand Up@@ -465,6 +469,10 @@ func TestOpenVSCodeDevContainer(t *testing.T) {
func TestOpenVSCodeDevContainer_NoAgentDirectory(t *testing.T) {
t.Parallel()

if runtime.GOOS != "linux" {
t.Skip("DevContainers are only supported for agents on Linux")
}

agentName := "agent1"

containerName := testutil.GetRandomName(t)
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp