NotificationsYou must be signed in to change notification settings
Fork906
Star10k

feat(site): open dev container in vscode#17182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

DanielleMaywood merged 3 commits intomainfromdm-open-devcontainer-vscode

Apr 3, 2025

Merged

feat(site): open dev container in vscode#17182

DanielleMaywood merged 3 commits intomainfromdm-open-devcontainer-vscode

Apr 3, 2025

Conversation

Copy link

Contributor

DanielleMaywood commentedApr 1, 2025•
edited
Loading

Closes#16426

Adds a new buttonVSCodeDevContainerButton for connecting to a dev container with VSCode.

github-actionsbot assignedDanielleMaywood

Apr 1, 2025

DanielleMaywood force-pushed thedm-open-devcontainer-vscode branch from863762b tof4b6ac3Compare

April 1, 2025 09:33

DanielleMaywood requested a review fromCopilot

April 1, 2025 09:35

CopilotAI reviewed

Apr 1, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces a new VSCodeDevContainerButton component to open a dev container in VSCode, updates related storybook stories, and refactors existing components to pass the full agent object rather than just the agent name.

Added the VSCodeDevContainerButton component with variant selection for VSCode and VSCode Insiders.
Updated storybook stories for VSCodeDevContainerButton.
Refactored AgentRow and AgentDevcontainerCard to use an agent object and updated the related prop names accordingly.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
site/src/modules/resources/VSCodeDevContainerButton/VSCodeDevContainerButton.tsx	New component for opening dev containers in VSCode with variant selection.
site/src/modules/resources/VSCodeDevContainerButton/VSCodeDevContainerButton.stories.tsx	Added stories for displaying the new VSCodeDevContainerButton component.
site/src/modules/resources/AgentRow.tsx	Updated prop from agentName to agent to match the agent object structure.
site/src/modules/resources/AgentDevcontainerCard.tsx	Refactored to use the agent object instead of a separate agentName prop.
site/src/modules/resources/AgentDevcontainerCard.stories.tsx	Updated stories to pass an agent object rather than an agent name string.

Comments suppressed due to low confidence (2)

site/src/modules/resources/AgentRow.tsx:292

Ensure that the receiving component and its prop types have been updated to accept the full agent object rather than just a string value. If not, update the component's prop definitions accordingly.

agent={agent}

site/src/modules/resources/AgentDevcontainerCard.tsx:61

Verify that the TerminalLink component's prop 'agentName' is correctly expecting a string derived from agent.name after the refactoring, or update its definition if necessary.