Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add the ability to hide preset parameters#17168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 9 commits intomainfromjjs/hide-preset-params
Apr 1, 2025

Conversation

SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedMar 31, 2025•
edited
Loading

This PR adds the ability to hide presets on the workspace creation form. When showing them, a clear indication is now made as to which inputs were preset and which weren't.

image

@SasSwartSasSwart requested a review fromCopilotMarch 31, 2025 09:41
Copilot

This comment was marked as resolved.

@SasSwartSasSwart marked this pull request as ready for reviewMarch 31, 2025 11:58
@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commentedApr 1, 2025•
edited
Loading

Code is ok, but design can be improved. Are you ok to hold this PR until we have a better design for it? I can get this done today or tomorrow 👍

@SasSwart
Copy link
ContributorAuthor

@BrunoQuaresma Sure, but consider getting in touch with@jaaydenh. He's rewriting the whole page under an experiment.

BrunoQuaresma reacted with thumbs up emoji

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving it for now. We can circle back on this during the create workspace form refactoring.

Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agree with Bruno regarding the design, looks good for now

@SasSwartSasSwart merged commit00e1ea4 intomainApr 1, 2025
30 checks passed
@SasSwartSasSwart deleted the jjs/hide-preset-params branchApril 1, 2025 20:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@jaaydenhjaaydenhjaaydenh approved these changes

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@SasSwart@BrunoQuaresma@jaaydenh
[8]ページ先頭
©2009-2025 Movatter.jp