Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: document that default GitHub app requires device flow#17162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EdwardAngert merged 3 commits intomainfrom16824-github-device-flow
Apr 6, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedMar 28, 2025•
edited
Loading

Issue

Closes#16824

Document that the default GitHub authentication app provided by Coder requires device flow, and that this behavior cannot be overridden.

Changes Made

Claude updated the GitHub authentication documentation to:

  1. Add a prominent warning in the Default Configuration section explaining that the default GitHub app requires device flow and ignores theCODER_OAUTH2_GITHUB_DEVICE_FLOW setting
  2. Clarify the Device Flow section to indicate that:
    • Device flow is always enabled for the default GitHub app
    • Device flow is optional for custom GitHub OAuth apps
    • TheCODER_OAUTH2_GITHUB_DEVICE_FLOW setting is ignored when using the default app

preview

🤖 Generated withClaude Code

Add clear documentation explaining that when using the default GitHub app:- Device flow is always enabled- Setting CODER_OAUTH2_GITHUB_DEVICE_FLOW=false will be ignored- This behavior only applies to the default GitHub appFixes#16824🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelMar 28, 2025
@EdwardAngertEdwardAngert self-assigned thisMar 28, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A minor suggestion but LGTM.

Copy link
Contributor

@hugodutkahugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The doc change looks good, but this PR doesn't close the issue. It doesn't address the 2nd requirement:

  1. log a warning in coder server

@EdwardAngert
Copy link
ContributorAuthor

The doc change looks good, but this PR doesn't close the issue. It doesn't address the 2nd requirement:

  1. log a warning in coder server

thanks@hugodutka - do you know if we already have some documentation on how a user would add a log in Coder server? I'm not seeing anything I can copy or point to in the docs

Co-authored-by: M Atif Ali <atif@coder.com>
@hugodutka
Copy link
Contributor

@EdwardAngert by "log a warning in coder server" I meant that coder itself should detect when a user tries to disable the device flow with the default config and log a warning in the terminal that this operation is invalid.

@EdwardAngert
Copy link
ContributorAuthor

@EdwardAngert by "log a warning in coder server" I meant that coder itself should detect when a user tries to disable the device flow with the default config and log a warning in the terminal that this operation is invalid.

I see,@hugodutka, thanks!

I created a new issue for that feature request#17228

this way, we can merge this PR as resolving the docs need and the eng teams can scope the feature request

hugodutka reacted with thumbs up emoji

@EdwardAngertEdwardAngert merged commitf475555 intomainApr 6, 2025
28 checks passed
@EdwardAngertEdwardAngert deleted the 16824-github-device-flow branchApril 6, 2025 01:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@hugodutkahugodutkahugodutka approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@stirbystirbyAwaiting requested review from stirby

Assignees

@EdwardAngertEdwardAngert

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that the default GitHub app requires device flow
3 participants
@EdwardAngert@hugodutka@matifali
[8]ページ先頭
©2009-2025 Movatter.jp