Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: update SMTP configuration in notifications docs#17161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EdwardAngert merged 2 commits intomainfrom16206-smtp-required-components
Apr 1, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedMar 28, 2025
edited
Loading

Issue

Closes#16206

(thanks@bjornrobertsson - not sure why I can't tag you as a reviewer)

Mismatch between the SMTP configuration UI and the documentation.

Verification

Claude verified this issue by examining:

  1. The current SMTP configuration code in the codebase
  2. The CLI help documentation for the server command
  3. The examples provided in the notifications documentation

The issue was confirmed by finding:

  • A reference to a deprecated variableCODER_NOTIFICATIONS_EMAIL_FORCE_TLS instead of the currentCODER_EMAIL_FORCE_TLS
  • Missing information about the port format required for the SMTP smarthost

Changes made

  1. Updated the--email-smarthost description to clarify that the format should include both hostname and port:(format: hostname:port)
  2. Fixed the reference to the TLS environment variable in the STARTTLS description, replacing the deprecated
    CODER_NOTIFICATIONS_EMAIL_FORCE_TLS with the correctCODER_EMAIL_FORCE_TLS

Additional information

The Gmail and Outlook examples in the documentation already correctly show the port included in the smarthost configuration, but the main description table needed to be updated to explicitly mention this requirement.

preview

🤖 Generated withClaude Code

Fix inconsistency in documentation for SMTP settings between UI and docs:- Update email-smarthost description to include port format- Fix incorrect reference to CODER_NOTIFICATIONS_EMAIL_FORCE_TLSFixes#16206🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelMar 28, 2025
@EdwardAngertEdwardAngert self-assigned thisMar 28, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@EdwardAngertEdwardAngert merged commit900e125 intomainApr 1, 2025
32 checks passed
@EdwardAngertEdwardAngert deleted the 16206-smtp-required-components branchApril 1, 2025 18:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@stirbystirbyAwaiting requested review from stirby

Assignees

@EdwardAngertEdwardAngert

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match the SMTP Required components between the UI and the formal documents
2 participants
@EdwardAngert@matifali

[8]ページ先頭

©2009-2025 Movatter.jp