- Notifications
You must be signed in to change notification settings - Fork906
docs: update SMTP configuration in notifications docs#17161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fix inconsistency in documentation for SMTP settings between UI and docs:- Update email-smarthost description to include port format- Fix incorrect reference to CODER_NOTIFICATIONS_EMAIL_FORCE_TLSFixes#16206🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
matifali approved these changesMar 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
900e125
intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Issue
Closes#16206
(thanks@bjornrobertsson - not sure why I can't tag you as a reviewer)
Mismatch between the SMTP configuration UI and the documentation.
Verification
Claude verified this issue by examining:
The issue was confirmed by finding:
CODER_NOTIFICATIONS_EMAIL_FORCE_TLS
instead of the currentCODER_EMAIL_FORCE_TLS
Changes made
--email-smarthost
description to clarify that the format should include both hostname and port:(format: hostname:port)
CODER_NOTIFICATIONS_EMAIL_FORCE_TLS
with the correctCODER_EMAIL_FORCE_TLS
Additional information
The Gmail and Outlook examples in the documentation already correctly show the port included in the smarthost configuration, but the main description table needed to be updated to explicitly mention this requirement.
preview
🤖 Generated withClaude Code