Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add rbac to templateversion+orgmember endpoints#1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 10 commits intomainfromstevenmasley/rbac_template_versions
May 25, 2022

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMay 24, 2022•
edited
Loading

RBAC on{templateversions} endpoints andassign org roles endpoint.

@EmyrkEmyrk changed the titlefeat: Add rbac to templateversion endpointsfeat: Add rbac to templateversion+orgmember endpointsMay 24, 2022
@EmyrkEmyrk marked this pull request as ready for reviewMay 24, 2022 16:46
Comment on lines +65 to +67
// ExtractOrganizationMemberParam grabs a user membership from the "organization" and "user" URL parameter.
// This middleware requires the ExtractUser and ExtractOrganization middleware higher in the stack
funcExtractOrganizationMemberParam(db database.Store)func(http.Handler) http.Handler {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

BeforeExtractOrganization did this with theAPIKey.UserID. That didn't make sense to me, as we use{user} forExtractUser.

So I changed this to use the user from{user} and org from{organization}

@EmyrkEmyrk requested review fromkylecarbs,spikecurtis andjohnstcn and removed request forkylecarbsMay 25, 2022 13:37
@EmyrkEmyrk merged commiteea8dc6 intomainMay 25, 2022
@EmyrkEmyrk deleted the stevenmasley/rbac_template_versions branchMay 25, 2022 16:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp