- Notifications
You must be signed in to change notification settings - Fork906
feat: split cli roles edit command into create and update commands#17121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
1ba6157
feat: split the org role edit command into two commands
brettkolodny566d432
chore: update tests and generate new golden files
brettkolodny3aabba3
chore: make gen
brettkolodny62b9d57
feat: add tests for update and create CLI
brettkolodnyc90838f
fix: add call to Parallel in test
brettkolodny9f0a8f1
Merge branch 'main' into brett-14239/refactor-cli-roles-edit-command
brettkolodnyd26c0d2
fix: spelling and grammar
brettkolodnybb7212d
Merge branch 'main' into brett-14239/refactor-cli-roles-edit-command
brettkolodnyf6559b3
fix: fix build errors
brettkolodnyc21e49b
Merge branch 'main' into brett-14239/refactor-cli-roles-edit-command
brettkolodny38bbc69
fix: update string in org roles cli test to reflect real output
brettkolodnyFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
221 changes: 163 additions & 58 deletionscli/organizationroles.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletionscli/testdata/coder_organizations_roles_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletionscli/testdata/coder_organizations_roles_create_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
coder v0.0.0-devel | ||
USAGE: | ||
coder organizations roles create [flags] <role_name> | ||
Create a new organization custom role | ||
- Run with an input.json file: | ||
$ coder organization -O <organization_name> roles create --stidin < | ||
role.json | ||
OPTIONS: | ||
--dry-run bool | ||
Does all the work, but does not submit the final updated role. | ||
--stdin bool | ||
Reads stdin for the json role definition to upload. | ||
-y, --yes bool | ||
Bypass prompts. | ||
——— | ||
Run `coder --help` for a list of global options. |
6 changes: 3 additions & 3 deletions...er_organizations_roles_edit_--help.golden → ..._organizations_roles_update_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.