Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): push dynamically generated templates with version name#17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
michaelvp411 merged 1 commit intomainfrommvp-dyamic-templates-fix
Mar 27, 2025

Conversation

michaelvp411
Copy link
Contributor

@michaelvp411michaelvp411 commentedMar 26, 2025•
edited by matifali
Loading

Closes#17031
Updated tempatespush.go

@michaelvp411michaelvp411 added the cliArea: CLI labelMar 26, 2025
@michaelvp411michaelvp411 self-assigned thisMar 26, 2025
@michaelvp411michaelvp411 changed the titlePush dynamically generated templates with version namefeat: push dynamically generated templates with version nameMar 26, 2025
@matifali
Copy link
Member

@michaelvp411 can you rebase onmain?
image
This button should do the job.

@michaelvp411
Copy link
ContributorAuthor

michaelvp411 commentedMar 26, 2025•
edited
Loading

Just rebased
@matifali

matifali reacted with thumbs up emoji

Copy link
Member

@matifalimatifali left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The changes look sane to me but I will wait for an engineer's approval to rule out any hidden caveats here.

@matifalimatifali changed the titlefeat: push dynamically generated templates with version namefeat(cli): push dynamically generated templates with version nameMar 26, 2025
@michaelvp411michaelvp411 merged commit0eec78d intomainMar 27, 2025
33 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

@aslilacaslilacaslilac approved these changes

@angrycubangrycubAwaiting requested review from angrycub

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@michaelvp411michaelvp411

Labels
cliArea: CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Pushing and testing dynamically generated templates fail their first test.
3 participants
@michaelvp411@matifali@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp