- Notifications
You must be signed in to change notification settings - Fork913
fix(dogfood/coder): add shutdown script and graceful agent shutdown#17110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -357,6 +357,14 @@ resource "coder_agent" "dev" { | ||
cd "${local.repo_dir}" && make clean | ||
cd "${local.repo_dir}/site" && pnpm install | ||
EOT | ||
shutdown_script = <<-EOT | ||
#!/usr/bin/env bash | ||
set -eux -o pipefail | ||
# Stop the Docker service to prevent errors during workspace destroy. | ||
sudo service docker stop | ||
EOT | ||
} | ||
# Add a cost so we get some quota usage in dev.coder.com | ||
@@ -418,6 +426,10 @@ resource "docker_container" "workspace" { | ||
# CPU limits are unnecessary since Docker will load balance automatically | ||
memory = data.coder_workspace_owner.me.name == "code-asher" ? 65536 : 32768 | ||
runtime = "sysbox-runc" | ||
# Ensure the workspace is given time to execute shutdown scripts. | ||
destroy_grace_seconds = 60 | ||
stop_timeout = 60 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Does this make sense as we actually do not stop the container but destroy it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I believe when a container is destroyed, it is first stopped. See motivation here#6174 which explains why we're setting both | ||
stop_signal = "SIGINT" | ||
env = [ | ||
"CODER_AGENT_TOKEN=${coder_agent.dev.token}", | ||
"USE_CAP_NET_ADMIN=true", | ||