- Notifications
You must be signed in to change notification settings - Fork913
fix(dogfood/coder): add shutdown script and graceful agent shutdown#17110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
By stopping Docker, we can hopefully avoid errors like this:```2025-03-26 12:14:53.280+02:00 Error: Error deleting container aa313fca0f72e59d4571afec898392e0ae34567d56c0ad15554c87394d2ca1e1: Error response from daemon: container aa313fca0f72e59d4571afec898392e0ae34567d56c0ad15554c87394d2ca1e1: driver "overlay2" failed to remove root filesystem: unlinkat /var/data/docker/overlay2/2e8e509237c79ebec972cccae9867f3bd6f71d49d4ed68db1b5ba229c3a2ff62/diff/var/lib/docker/overlay2/9c7c4ab0187ece1ca270d146090a8e852808996279d103cb394b2821c472af4c/diff/usr/lib/python3/dist-packages/ansible_collections: directory not empty```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚢
| @@ -418,6 +426,10 @@ resource "docker_container" "workspace" { | |||
| # CPU limits are unnecessary since Docker will load balance automatically | |||
| memory = data.coder_workspace_owner.me.name == "code-asher" ? 65536 : 32768 | |||
| runtime = "sysbox-runc" | |||
| # Ensure the workspace is given time to execute shutdown scripts. | |||
| destroy_grace_seconds = 60 | |||
| stop_timeout = 60 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this make sense as we actually do not stop the container but destroy it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe when a container is destroyed, it is first stopped. See motivation here#6174 which explains why we're setting bothdestroy_grace_seconds andstop_timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
310f148 intomainUh oh!
There was an error while loading.Please reload this page.
By stopping Docker, we can hopefully avoid errors like this: