- Notifications
You must be signed in to change notification settings - Fork906
feat: add name to workspace agent devcontainers#17089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In the presence of multiple devcontainers, it would be nice todifferentiate them by name. This change inherits the resource name fromterraform.
| @@ -195,6 +195,7 @@ message Script { | |||
| message Devcontainer { | |||
| string workspace_folder = 1; | |||
| string config_path = 2; | |||
| string name = 3; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@spikecurtis Do we need to bump the version again? Or is it fine if this makes it into the release cut?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One version bump per release is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO we don't need a separate version bump as long as this gets into the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks fine to me, we have already added a version bump for the new field previously so this should be fine as long as it get into the release (either via cherry-pick or otherwise).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me
5c8cac9 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
In the presence of multiple devcontainers, it would be nice to
differentiate them by name. This change inherits the resource name from
terraform.
Ref#17076