- Notifications
You must be signed in to change notification settings - Fork923
feat: adds device_id, device_os, and coder_desktop_version to telemetry#17086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
1a803fe todea30baComparedea30ba to91f5fbaCompare
johnstcn left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have any blocking concerns, just some suggestions below.
Uh oh!
There was an error while loading.Please reload this page.
| func requireEqualOrBothNil[T any](t testing.TB, a, b *T) { | ||
| t.Helper() | ||
| if a != nil && b != nil { | ||
| require.Equal(t, *a, *b) | ||
| return | ||
| } | ||
| require.Equal(t, a, b) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
suggestion: potentially usefultesutil candidate?
117e4c2 intomainUh oh!
There was an error while loading.Please reload this page.
Merge activity
|
👀 |
Uh oh!
There was an error while loading.Please reload this page.
Records the Device ID, Device OS and Coder Desktop version to telemetry.
These values are provided by the Coder Desktop client in the StartRequest method of the VPN protocol. We render them as an HTTP header to transmit to Coderd, where they are decoded and added to telemetry.