- Notifications
You must be signed in to change notification settings - Fork927
ci: standardize on go 1.22.12#17047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it makes me sad but I will allow it
Uh oh!
There was an error while loading.Please reload this page.
b2a8edc tod0c9cf8Compare| @@ -2,14 +2,14 @@ FROM rust:slim@sha256:9abf10cc84dfad6ace1b0aae3951dc5200f467c593394288c11db1e17b | |||
| # Install rust helper programs | |||
| # ENV CARGO_NET_GIT_FETCH_WITH_CLI=true | |||
| ENV CARGO_INSTALL_ROOT=/tmp/ | |||
| RUN cargo installexa bat ripgreptypos-cli watchexec-cli && \ | |||
| RUN cargo install typos-cli watchexec-cli && \ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
review:bat was failing to build for me locally, butbat,exa, andripgrep can now be installed viaapt.
| # go-fuzz for fuzzy testing. they don't publish releases so we rely on latest. | ||
| go install github.com/dvyukov/go-fuzz/go-fuzz@latest && \ | ||
| go install github.com/dvyukov/go-fuzz/go-fuzz-build@latest && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
review: this was failing to build with a tools dependency issue but it doesn't seem to be required since go 1.18?
445a059 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The version of Go in our dogfood Dockerfile was seemingly unintentionally bumped in#16894
We need to keep our various Go versions in sync, otherwise things get confusing: