Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): add format option to inbox notifications watch endpoint#17034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
defelmnq merged 4 commits intomainfrominbox-notif/internal-523
Mar 21, 2025

Conversation

defelmnq
Copy link
Contributor

@defelmnqdefelmnq commentedMar 21, 2025•
edited
Loading

This PR aims to allow clients to use different format for the title and content of inbox notifications - on the watch endpoint.

This solution will help to have it working and formatted differently on VSCode, WebUI ...
Related to this issue

@defelmnqdefelmnq changed the titleupdate doc and remove plaintext formatfeat(coderd): add format option to inbox notifications watch endpointMar 21, 2025
@defelmnqdefelmnq marked this pull request as ready for reviewMarch 21, 2025 14:27
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me:shipit:

@defelmnqdefelmnq requested a review frommafredriMarch 21, 2025 15:11
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@defelmnqdefelmnq merged commit82e3773 intomainMar 21, 2025
32 checks passed
@defelmnqdefelmnq deleted the inbox-notif/internal-523 branchMarch 21, 2025 15:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@defelmnqdefelmnq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@defelmnq@mafredri@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp