Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): add open app <workspace> <app-slug> command#17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/cli-open-coder-app
Mar 21, 2025

Conversation

@johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 20, 2025•
edited
Loading

Fixes#17009

Adds a CLI commandcoder open app <workspace> <app-slug> that allows opening arbitrarycoder_apps via the CLI.

Users can optionally specify a preferred region for workspace applications.

@johnstcnjohnstcn self-assigned thisMar 20, 2025
@johnstcnjohnstcnforce-pushed thecj/cli-open-coder-app branch 2 times, most recently from70e04ba toa778d6cCompareMarch 21, 2025 12:38
@johnstcnjohnstcn marked this pull request as ready for reviewMarch 21, 2025 13:00
}
}

funcTest_buildAppLinkURL(t*testing.T) {
Copy link
MemberAuthor

@johnstcnjohnstcnMar 21, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review: I adapted the test cases fromapp.test.ts. If you have other suggestions for test cases, I'd be happy to add them!

u.RawQuery=q.Encode()
// encodeURIComponent replaces spaces with %20 but url.QueryEscape replaces them with +.
// We replace them with %20 to match the TypeScript implementation.
u.RawQuery=strings.ReplaceAll(u.RawQuery,"+","%20")
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review: I'm not sure if this is strictly necessary? Did it for completeness' sake.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to see a slightly better UX, but otherwise this looks great. Nice work!

@johnstcnjohnstcn requested a review frommafredriMarch 21, 2025 15:04
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Niiice, thanks for improving the UX!

johnstcn reacted with heart emoji
@johnstcnjohnstcn merged commit0474888 intomainMar 21, 2025
32 checks passed
@johnstcnjohnstcn deleted the cj/cli-open-coder-app branchMarch 21, 2025 15:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@hugodutkahugodutkaAwaiting requested review from hugodutka

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allowcoder open to work with any genericcoder_app

3 participants

@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp