- Notifications
You must be signed in to change notification settings - Fork905
feat: filter users by github user id in the users list CLI command#17029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| p.Errors = append(p.Errors, codersdk.ValidationError{ | ||
| Field: queryParam, | ||
| Detail: fmt.Sprintf("Query param %q must be a valid 64-bit integer: %s", queryParam, err.Error()), | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
suggestion: explicitly return the zero value here
| WHEN @github_com_user_id :: bigint != 0 THEN | ||
| github_com_user_id = @github_com_user_id | ||
| ELSE true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this is worth blocking on, but the comment for this column mentions:
At time of implementation, this is used to check if the user has starred the Coder repository.It may be worth updating this comment in a follow-up now that it's becoming more of a load-bearing number.
f29590e tod08dd3bComparea71aa20 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add the
--github-user-idoption tocoder users list, which makes the command only return users with a matching GitHub user id. This will enablehttps://github.com/coder/start-workspace-action to find a Coder user that corresponds to a GitHub user requesting to start a workspace.