- Notifications
You must be signed in to change notification settings - Fork913
fix: use navigator.locale to evaluate time format#17025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -79,6 +79,7 @@ export const ScheduleForm: FC<ScheduleFormProps> = ({ | ||
}, | ||
}); | ||
const getFieldHelpers = getFormHelpers<ScheduleFormValues>(form, submitError); | ||
const browserLocale = navigator.language || "en-US"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Disappointed we have to uselanguage as an approximation 😔. I prefer to use English US for text and UI language but Finland is used for numbers, time and currency. Yet this is not available to the browser (AFAICT). | ||
return ( | ||
<Form onSubmit={form.handleSubmit}> | ||
@@ -127,7 +128,12 @@ export const ScheduleForm: FC<ScheduleFormProps> = ({ | ||
disabled | ||
fullWidth | ||
label="Next occurrence" | ||
value={quietHoursDisplay( | ||
browserLocale, | ||
form.values.time, | ||
form.values.timezone, | ||
now, | ||
)} | ||
/> | ||
<div> | ||
Uh oh!
There was an error while loading.Please reload this page.