- Notifications
You must be signed in to change notification settings - Fork907
fix: use navigator.locale to evaluate time format#17025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍🏻
| @@ -79,6 +79,7 @@ export const ScheduleForm: FC<ScheduleFormProps> = ({ | |||
| }, | |||
| }); | |||
| const getFieldHelpers = getFormHelpers<ScheduleFormValues>(form, submitError); | |||
| const browserLocale = navigator.language || "en-US"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Disappointed we have to uselanguage as an approximation 😔. I prefer to use English US for text and UI language but Finland is used for numbers, time and currency. Yet this is not available to the browser (AFAICT).
287e319 intomainUh oh!
There was an error while loading.Please reload this page.
Fixes:#15452
It's second attempt.
This time we use
navigator.localeto check the browser/OS locale.