NotificationsYou must be signed in to change notification settings
Fork906
Star10k

feat: add user_tailnet_connections to telemetry#17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

spikecurtis merged 1 commit intomainfromspike/coder-desktop-telemetry

Mar 20, 2025

Merged

feat: add user_tailnet_connections to telemetry#17018

spikecurtis merged 1 commit intomainfromspike/coder-desktop-telemetry

Mar 20, 2025

Conversation

Copy link

Contributor

spikecurtis commentedMar 20, 2025•
edited
Loading

Summary

Add UserTailnetConnection struct to track desktop client connections
Add new field to Snapshot struct for telemetry
Data collection to be implemented in a future PR

relates to coder/nexus#197

feat: add user_tailnet_connections to telemetry

8d6aedf

Add UserTailnetConnection struct and field to Snapshot for tracking desktop connections.Data collection will be implemented in a future PR.

github-actionsbot assignedspikecurtis

Mar 20, 2025

spikecurtis marked this pull request as ready for review

March 20, 2025 10:18

spikecurtis requested review fromdeansheather andhugodutka

March 20, 2025 10:19

hugodutka approved these changes

Mar 20, 2025

View reviewed changes

deansheather approved these changes

Mar 20, 2025

View reviewed changes

coder deleted a comment fromdeansheather

Mar 20, 2025

Copy link

Contributor

hugodutka commentedMar 20, 2025

@deansheather I somehow deleted your comment - I'm not even sure how that happened. I didn't mean to. Sorry!

Copy link

ContributorAuthor

spikecurtis commentedMar 20, 2025

I think this comment was deleted by mistake.@deansheather

We should probably add a unique ID for the event, can just be a uuid.New()

I feel likeconnected_at, user_id, peer_id should be plenty unique. It would be wild to get multiple connections using the same peer token (only way to get the same PeerID) at exactly the same instant, and the extra column could really add up in terms of space at the scale of telemetry.