Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add fallback icons for notifications#17013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
defelmnq merged 11 commits intomainfromnotif-inbox/internal-522
Mar 28, 2025
Merged
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
improve tests
  • Loading branch information
@defelmnq
defelmnq committedMar 27, 2025
commitd22f0b56e23a88ef4ad285e33987e1a563f89cdc
28 changes: 17 additions & 11 deletionscoderd/inboxnotifications_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -869,6 +869,8 @@ func TestInboxNotifications_MarkAllAsRead(t *testing.T) {
}

func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) {
t.Parallel()

tests := []struct {
name string
icon string
Expand DownExpand Up@@ -913,17 +915,21 @@ func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) {
for _, tt := range tests {
tt := tt

notif := codersdk.InboxNotification{
ID: uuid.New(),
UserID: uuid.New(),
TemplateID: tt.templateID,
Title: "notification title",
Content: "notification content",
Icon: tt.icon,
CreatedAt: time.Now(),
}
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

coderd.SetInboxNotificationIcon(&notif)
require.Equal(t, tt.expectedIcon, notif.Icon)
notif := codersdk.InboxNotification{
ID: uuid.New(),
UserID: uuid.New(),
TemplateID: tt.templateID,
Title: "notification title",
Content: "notification content",
Icon: tt.icon,
CreatedAt: time.Now(),
}

coderd.SetInboxNotificationIcon(&notif)
require.Equal(t, tt.expectedIcon, notif.Icon)
})
}
}
Loading

[8]ページ先頭

©2009-2025 Movatter.jp