- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: add fallback icons for notifications#17013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
f9662a8 work on fallback icons
defelmnqf2c57f4 merge with main
defelmnq033d78a add tests for fallback
defelmnqa633e8e Merge remote-tracking branch 'origin/main' into notif-inbox/internal-522
defelmnq0469e57 add tests and improve fallback logic
defelmnqd22f0b5 improve tests
defelmnq4c4527c improve testings on icons
defelmnq783b04b improve testings on icons
defelmnq3ac9d92 nit changes
defelmnq0b2496e nit changes
defelmnqdc38924 Merge branch 'main' into notif-inbox/internal-522
defelmnqFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
improve tests
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd22f0b56e23a88ef4ad285e33987e1a563f89cdc
There are no files selected for viewing
28 changes: 17 additions & 11 deletionscoderd/inboxnotifications_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -869,6 +869,8 @@ func TestInboxNotifications_MarkAllAsRead(t *testing.T) { | ||
| } | ||
| func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) { | ||
| t.Parallel() | ||
| tests := []struct { | ||
| name string | ||
| icon string | ||
| @@ -913,17 +915,21 @@ func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) { | ||
| for _, tt := range tests { | ||
| tt := tt | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| notif := codersdk.InboxNotification{ | ||
| ID: uuid.New(), | ||
| UserID: uuid.New(), | ||
| TemplateID: tt.templateID, | ||
| Title: "notification title", | ||
| Content: "notification content", | ||
| Icon: tt.icon, | ||
| CreatedAt: time.Now(), | ||
| } | ||
| coderd.SetInboxNotificationIcon(¬if) | ||
mtojek marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| require.Equal(t, tt.expectedIcon, notif.Icon) | ||
| }) | ||
| } | ||
| } | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.