Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: allow specifying devcontainer on agent in terraform#16997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 23 commits intomainfrommafredri/feat-add-agent-devcontainers
Mar 20, 2025

Conversation

@mafredri
Copy link
Member

@mafredrimafredri commentedMar 19, 2025•
edited
Loading

This change allows specifying devcontainers in terraform and plumbs it through to the agent via agent manifest.

This will be used for autostarting devcontainers in a workspace.

Depends oncoder/terraform-provider-coder#368
Updates#16423

@mafredrimafredriforce-pushed themafredri/feat-add-agent-devcontainers branch from8e2d86e to2d72c03CompareMarch 19, 2025 13:57
@mafredrimafredriforce-pushed themafredri/feat-add-agent-devcontainers branch from05e50d7 to885869fCompareMarch 19, 2025 14:24
@mafredrimafredri marked this pull request as ready for reviewMarch 19, 2025 16:07
@mafredrimafredriforce-pushed themafredri/feat-add-agent-devcontainers branch 2 times, most recently from26bd7df to2c9ccf2CompareMarch 19, 2025 16:22
Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work!

EDIT: I think you need to fix something in the typegen though:

https://github.com/coder/coder/actions/runs/13968677521/job/39104925348?pr=16997#step:11:992

@mafredrimafredriforce-pushed themafredri/feat-add-agent-devcontainers branch fromb5c5b4c to1544b49CompareMarch 20, 2025 16:02
@mafredrimafredriforce-pushed themafredri/feat-add-agent-devcontainers branch from1544b49 to82df8d6CompareMarch 20, 2025 16:08
@mafredrimafredri merged commit69ba27e intomainMar 20, 2025
33 of 35 checks passed
@mafredrimafredri deleted the mafredri/feat-add-agent-devcontainers branchMarch 20, 2025 17:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodAwaiting requested review from DanielleMaywood

@SasSwartSasSwartAwaiting requested review from SasSwart

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mafredri@johnstcn@spikecurtis@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp