Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025
diff --git a/coderd/database/migrations/000126_login_type_none.up.sql b/coderd/database/migrations/000126_login_type_none.up.sql
 -- This migration has been modified after its initial commit.
 -- The original disregarded the warning in create_migration.sh.
 -- As a result, it was not possible to insert a user with the "none" login type
 -- in a migration.
 -- The new implementation makes the same changes as the original, but
 --adhered tothewarning in create_migration.sh to allow the insertion of
 -- a user with the "none" login type. This was necessary for prebuilds.
 -- For more information, see: https://github.com/coder/coder/pull/16916#discussion_r1998758887
 --takes into accountthemessage in create_migration.sh. This is done
 --to allow the insertion ofa user with the "none" login type in later migrations.

 CREATE TYPE new_logintype AS ENUM (
  'password',
  'github',
Original file line number	Diff line number	Diff line change
		@@ -1,11 +1,8 @@
		-- This migration has been modified after its initial commit.
		-- The original disregarded the warning in create_migration.sh.
		-- As a result, it was not possible to insert a user with the "none" login type
		-- in a migration.
		-- The new implementation makes the same changes as the original, but
Copy link Contributor dannykoppingMar 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Nit: this comment should rather just going into the PR description, and the original argument should be copied over as well. Linking to a GH commit might not always work, or be difficult to find once the comment is resolved. Copy link ContributorAuthor SasSwartMar 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'm going to keep a trimmed version of the comment in the migration if its all the same, but I will update the PR description with some more detail. dannykopping reacted with thumbs up emoji Copy link Contributor dannykoppingMar 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Sounds good; for consistency should it not go in both files then?
		--adhered tothewarning in create_migration.sh to allow the insertion of
		-- a user with the "none" login type. This was necessary for prebuilds.
		-- For more information, see: https://github.com/coder/coder/pull/16916#discussion_r1998758887
		--takes into accountthemessage in create_migration.sh. This is done
		--to allow the insertion ofa user with the "none" login type in later migrations.

		CREATE TYPE new_logintype AS ENUM (
		'password',
		'github',
Expand Down