Apr 7, 2025 · Mar 12, 2025 · Mar 13, 2025 · Mar 13, 2025 · Mar 13, 2025 · Mar 13, 2025
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return q.db.GetPresetByWorkspaceBuildID(ctx, workspaceID)
 }

 func (q *querier)GetPresetParametersByTemplateVersionID(ctx context.Context,templateVersionID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
 func (q *querier)GetPresetParametersByPresetID(ctx context.Context,presetID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
 // An actor can read template version presets if they can read the related template version.
 _, err := q.GetTemplateVersionByID(ctx, templateVersionID)
 _, err := q.GetPresetByID(ctx, presetID)
 if err != nil {
 return nil, err
 }

 return q.db.GetPresetParametersByPresetID(ctx, presetID)
 }

 func (q *querier) GetPresetParametersByTemplateVersionID(ctx context.Context, args uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
 // An actor can read template version presets if they can read the related template version.
 _, err := q.GetTemplateVersionByID(ctx, args)
 if err != nil {
 return nil, err
 }

 return q.db.GetPresetParametersByTemplateVersionID(ctx,templateVersionID)
 return q.db.GetPresetParametersByTemplateVersionID(ctx,args)
 }

 func (q *querier) GetPresetsBackoff(ctx context.Context, lookback time.Time) ([]database.GetPresetsBackoffRow, error) {
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
 method.Name == "PGLocks" {
 continue
 }
 // Log the name of the last method, so if there is a panic, it is
 // easy to know which method failed.
 // t.Log(method.Name)
 // Call the function. Any infinite recursion will stack overflow.
 TemplateVersionID: workspaceBuild.TemplateVersionID,
 Name:              "test",
 }
 preset, err := db.InsertPreset(context.Background(), insertPresetParams)
 require.NoError(s.T(), err)
 preset := dbgen.Preset(s.T(), db, insertPresetParams)
 insertPresetParametersParams := database.InsertPresetParametersParams{
 TemplateVersionPresetID: preset.ID,
 Names:                   []string{"test"},
 })

 check.Args(database.OrganizationMembersParams{
 OrganizationID:uuid.UUID{},
 UserID:uuid.UUID{},
 OrganizationID:o.ID,
 UserID:u.ID,
 }).Asserts(
 mem, policy.ActionRead,
 )
 ErrorsWithInMemDB(sql.ErrNoRows).
 Returns([]database.ParameterSchema{})
 }))
 s.Run("GetPresetByWorkspaceBuildID", s.Subtest(func(db database.Store, check *expects) {
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })
 preset, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)
 workspace := dbgen.Workspace(s.T(), db, database.WorkspaceTable{
 OrganizationID: org.ID,
 OwnerID:        user.ID,
 TemplateID:     template.ID,
 })
 job := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{
 OrganizationID: org.ID,
 })
 workspaceBuild := dbgen.WorkspaceBuild(s.T(), db, database.WorkspaceBuild{
 WorkspaceID:             workspace.ID,
 TemplateVersionID:       templateVersion.ID,
 TemplateVersionPresetID: uuid.NullUUID{UUID: preset.ID, Valid: true},
 InitiatorID:             user.ID,
 JobID:                   job.ID,
 })
 _, err = db.GetPresetByWorkspaceBuildID(context.Background(), workspaceBuild.ID)
 require.NoError(s.T(), err)
 check.Args(workspaceBuild.ID).Asserts(rbac.ResourceTemplate, policy.ActionRead)
 }))
 s.Run("GetPresetParametersByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
 ctx := context.Background()
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })
 preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)
 _, err = db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
 TemplateVersionPresetID: preset.ID,
 Names:                   []string{"test"},
 Values:                  []string{"test"},
 })
 require.NoError(s.T(), err)
 presetParameters, err := db.GetPresetParametersByTemplateVersionID(ctx, templateVersion.ID)
 require.NoError(s.T(), err)

 check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presetParameters)
 }))
 s.Run("GetPresetsByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
 ctx := context.Background()
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })

 _, err := db.InsertPreset(ctx, database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)

 presets, err := db.GetPresetsByTemplateVersionID(ctx, templateVersion.ID)
 require.NoError(s.T(), err)

 check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presets)
 }))
 s.Run("GetWorkspaceAppsByAgentIDs", s.Subtest(func(db database.Store, check *expects) {
 dbtestutil.DisableForeignKeysAndTriggers(s.T(), db)
 aWs := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
 }

 func (s *MethodTestSuite) TestPrebuilds() {
 s.Run("GetPresetByWorkspaceBuildID", s.Subtest(func(db database.Store, check *expects) {
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })
 preset, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)
 workspace := dbgen.Workspace(s.T(), db, database.WorkspaceTable{
 OrganizationID: org.ID,
 OwnerID:        user.ID,
 TemplateID:     template.ID,
 })
 job := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{
 OrganizationID: org.ID,
 })
 workspaceBuild := dbgen.WorkspaceBuild(s.T(), db, database.WorkspaceBuild{
 WorkspaceID:             workspace.ID,
 TemplateVersionID:       templateVersion.ID,
 TemplateVersionPresetID: uuid.NullUUID{UUID: preset.ID, Valid: true},
 InitiatorID:             user.ID,
 JobID:                   job.ID,
 })
 _, err = db.GetPresetByWorkspaceBuildID(context.Background(), workspaceBuild.ID)
 require.NoError(s.T(), err)
 check.Args(workspaceBuild.ID).Asserts(rbac.ResourceTemplate, policy.ActionRead)
 }))
 s.Run("GetPresetParametersByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
 ctx := context.Background()
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })
 preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)
 insertedParameters, err := db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
 TemplateVersionPresetID: preset.ID,
 Names:                   []string{"test"},
 Values:                  []string{"test"},
 })
 require.NoError(s.T(), err)
 check.
 Args(templateVersion.ID).
 Asserts(template.RBACObject(), policy.ActionRead).
 Returns(insertedParameters)
 }))
 s.Run("GetPresetParametersByPresetID", s.Subtest(func(db database.Store, check *expects) {
 ctx := context.Background()
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })
 preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)
 insertedParameters, err := db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
 TemplateVersionPresetID: preset.ID,
 Names:                   []string{"test"},
 Values:                  []string{"test"},
 })
 require.NoError(s.T(), err)
 check.
 Args(preset.ID).
 Asserts(template.RBACObject(), policy.ActionRead).
 Returns(insertedParameters)
 }))
 s.Run("GetPresetsByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
 ctx := context.Background()
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 template := dbgen.Template(s.T(), db, database.Template{
 CreatedBy:      user.ID,
 OrganizationID: org.ID,
 })
 templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
 TemplateID:     uuid.NullUUID{UUID: template.ID, Valid: true},
 OrganizationID: org.ID,
 CreatedBy:      user.ID,
 })

 _, err := db.InsertPreset(ctx, database.InsertPresetParams{
 TemplateVersionID: templateVersion.ID,
 Name:              "test",
 })
 require.NoError(s.T(), err)

 presets, err := db.GetPresetsByTemplateVersionID(ctx, templateVersion.ID)
 require.NoError(s.T(), err)

 check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presets)
 }))
 s.Run("ClaimPrebuiltWorkspace", s.Subtest(func(db database.Store, check *expects) {
 org := dbgen.Organization(s.T(), db, database.Organization{})
 user := dbgen.User(s.T(), db, database.User{})
 UUID:  template.ID,
 Valid: true,
 },
 OrganizationID: org.ID,
 InvalidateAfterSecs: preset.InvalidateAfterSecs,
 OrganizationID:      org.ID,
 })
 }))
 }
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
 return database.TemplateVersionPreset{}, sql.ErrNoRows
 }

 func (q *FakeQuerier) GetPresetParametersByPresetID(_ context.Context, presetID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()

 parameters := make([]database.TemplateVersionPresetParameter, 0)
 for _, parameter := range q.presetParameters {
 if parameter.TemplateVersionPresetID != presetID {
 continue
 }
 parameters = append(parameters, parameter)
 }

 return parameters, nil
 }

 func (q *FakeQuerier) GetPresetParametersByTemplateVersionID(_ context.Context, templateVersionID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()
 continue
 }
 parameters = append(parameters, parameter)
 break
 }
 }

 TemplateVersionID: arg.TemplateVersionID,
 Name:              arg.Name,
 CreatedAt:         arg.CreatedAt,
 DesiredInstances:  arg.DesiredInstances,
 InvalidateAfterSecs: sql.NullInt32{
 Int32: 0,
 Valid: true,
 },
 }
 q.presets = append(q.presets, preset)
 return preset, nil
diff --git a/coderd/database/dbmetrics/querymetrics.go b/coderd/database/dbmetrics/querymetrics.go
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
diff --git a/coderd/database/querier.go b/coderd/database/querier.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2187,14 +2187,24 @@ func (q *querier) GetPresetByWorkspaceBuildID(ctx context.Context, workspaceID u
		return q.db.GetPresetByWorkspaceBuildID(ctx, workspaceID)
		}

		func (q *querier)GetPresetParametersByTemplateVersionID(ctx context.Context,templateVersionID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
		func (q *querier)GetPresetParametersByPresetID(ctx context.Context,presetID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
		// An actor can read template version presets if they can read the related template version.
		_, err := q.GetTemplateVersionByID(ctx, templateVersionID)
		_, err := q.GetPresetByID(ctx, presetID)
		if err != nil {
		return nil, err
		}

		return q.db.GetPresetParametersByPresetID(ctx, presetID)
		}

		func (q *querier) GetPresetParametersByTemplateVersionID(ctx context.Context, args uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
		// An actor can read template version presets if they can read the related template version.
		_, err := q.GetTemplateVersionByID(ctx, args)
		if err != nil {
		return nil, err
		}

		return q.db.GetPresetParametersByTemplateVersionID(ctx,templateVersionID)
		return q.db.GetPresetParametersByTemplateVersionID(ctx,args)
		}

		func (q *querier) GetPresetsBackoff(ctx context.Context, lookback time.Time) ([]database.GetPresetsBackoffRow, error) {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -182,7 +182,6 @@ func TestDBAuthzRecursive(t *testing.T) {
		method.Name == "PGLocks" {
		continue
		}
		// Log the name of the last method, so if there is a panic, it is
Copy link Contributor dannykoppingApr 7, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Intentional deletion?
		// easy to know which method failed.
		// t.Log(method.Name)
		// Call the function. Any infinite recursion will stack overflow.
Expand DownExpand Up		@@ -969,8 +968,7 @@ func (s *MethodTestSuite) TestOrganization() {
		TemplateVersionID: workspaceBuild.TemplateVersionID,
		Name: "test",
		}
		preset, err := db.InsertPreset(context.Background(), insertPresetParams)
		require.NoError(s.T(), err)
		preset := dbgen.Preset(s.T(), db, insertPresetParams)
		insertPresetParametersParams := database.InsertPresetParametersParams{
		TemplateVersionPresetID: preset.ID,
		Names: []string{"test"},
Expand DownExpand Up		@@ -1027,8 +1025,8 @@ func (s *MethodTestSuite) TestOrganization() {
		})

		check.Args(database.OrganizationMembersParams{
		OrganizationID:uuid.UUID{},
		UserID:uuid.UUID{},
		OrganizationID:o.ID,
		UserID:u.ID,
		}).Asserts(
		mem, policy.ActionRead,
		)
Expand DownExpand Up		@@ -3906,96 +3904,6 @@ func (s *MethodTestSuite) TestSystemFunctions() {
		ErrorsWithInMemDB(sql.ErrNoRows).
		Returns([]database.ParameterSchema{})
		}))
		s.Run("GetPresetByWorkspaceBuildID", s.Subtest(func(db database.Store, check *expects) {
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})
		preset, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)
		workspace := dbgen.Workspace(s.T(), db, database.WorkspaceTable{
		OrganizationID: org.ID,
		OwnerID: user.ID,
		TemplateID: template.ID,
		})
		job := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{
		OrganizationID: org.ID,
		})
		workspaceBuild := dbgen.WorkspaceBuild(s.T(), db, database.WorkspaceBuild{
		WorkspaceID: workspace.ID,
		TemplateVersionID: templateVersion.ID,
		TemplateVersionPresetID: uuid.NullUUID{UUID: preset.ID, Valid: true},
		InitiatorID: user.ID,
		JobID: job.ID,
		})
		_, err = db.GetPresetByWorkspaceBuildID(context.Background(), workspaceBuild.ID)
		require.NoError(s.T(), err)
		check.Args(workspaceBuild.ID).Asserts(rbac.ResourceTemplate, policy.ActionRead)
		}))
		s.Run("GetPresetParametersByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
		ctx := context.Background()
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})
		preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)
		_, err = db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
		TemplateVersionPresetID: preset.ID,
		Names: []string{"test"},
		Values: []string{"test"},
		})
		require.NoError(s.T(), err)
		presetParameters, err := db.GetPresetParametersByTemplateVersionID(ctx, templateVersion.ID)
		require.NoError(s.T(), err)

		check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presetParameters)
		}))
		s.Run("GetPresetsByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
		ctx := context.Background()
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})

		_, err := db.InsertPreset(ctx, database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)

		presets, err := db.GetPresetsByTemplateVersionID(ctx, templateVersion.ID)
		require.NoError(s.T(), err)

		check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presets)
		}))
		s.Run("GetWorkspaceAppsByAgentIDs", s.Subtest(func(db database.Store, check *expects) {
		dbtestutil.DisableForeignKeysAndTriggers(s.T(), db)
		aWs := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
Expand DownExpand Up		@@ -4839,6 +4747,125 @@ func (s *MethodTestSuite) TestNotifications() {
		}

		func (s *MethodTestSuite) TestPrebuilds() {
		s.Run("GetPresetByWorkspaceBuildID", s.Subtest(func(db database.Store, check *expects) {
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})
		preset, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)
		workspace := dbgen.Workspace(s.T(), db, database.WorkspaceTable{
		OrganizationID: org.ID,
		OwnerID: user.ID,
		TemplateID: template.ID,
		})
		job := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{
		OrganizationID: org.ID,
		})
		workspaceBuild := dbgen.WorkspaceBuild(s.T(), db, database.WorkspaceBuild{
		WorkspaceID: workspace.ID,
		TemplateVersionID: templateVersion.ID,
		TemplateVersionPresetID: uuid.NullUUID{UUID: preset.ID, Valid: true},
		InitiatorID: user.ID,
		JobID: job.ID,
		})
		_, err = db.GetPresetByWorkspaceBuildID(context.Background(), workspaceBuild.ID)
		require.NoError(s.T(), err)
		check.Args(workspaceBuild.ID).Asserts(rbac.ResourceTemplate, policy.ActionRead)
		}))
		s.Run("GetPresetParametersByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
		ctx := context.Background()
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})
		preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)
		insertedParameters, err := db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
		TemplateVersionPresetID: preset.ID,
		Names: []string{"test"},
		Values: []string{"test"},
		})
		require.NoError(s.T(), err)
		check.
		Args(templateVersion.ID).
		Asserts(template.RBACObject(), policy.ActionRead).
		Returns(insertedParameters)
		}))
		s.Run("GetPresetParametersByPresetID", s.Subtest(func(db database.Store, check *expects) {
		ctx := context.Background()
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})
		preset, err := db.InsertPreset(ctx, database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)
		insertedParameters, err := db.InsertPresetParameters(ctx, database.InsertPresetParametersParams{
		TemplateVersionPresetID: preset.ID,
		Names: []string{"test"},
		Values: []string{"test"},
		})
		require.NoError(s.T(), err)
		check.
		Args(preset.ID).
		Asserts(template.RBACObject(), policy.ActionRead).
		Returns(insertedParameters)
		}))
		s.Run("GetPresetsByTemplateVersionID", s.Subtest(func(db database.Store, check *expects) {
		ctx := context.Background()
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
		template := dbgen.Template(s.T(), db, database.Template{
		CreatedBy: user.ID,
		OrganizationID: org.ID,
		})
		templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
		TemplateID: uuid.NullUUID{UUID: template.ID, Valid: true},
		OrganizationID: org.ID,
		CreatedBy: user.ID,
		})

		_, err := db.InsertPreset(ctx, database.InsertPresetParams{
		TemplateVersionID: templateVersion.ID,
		Name: "test",
		})
		require.NoError(s.T(), err)

		presets, err := db.GetPresetsByTemplateVersionID(ctx, templateVersion.ID)
		require.NoError(s.T(), err)

		check.Args(templateVersion.ID).Asserts(template.RBACObject(), policy.ActionRead).Returns(presets)
		}))
		s.Run("ClaimPrebuiltWorkspace", s.Subtest(func(db database.Store, check *expects) {
		org := dbgen.Organization(s.T(), db, database.Organization{})
		user := dbgen.User(s.T(), db, database.User{})
Expand DownExpand Up		@@ -4923,7 +4950,8 @@ func (s *MethodTestSuite) TestPrebuilds() {
		UUID: template.ID,
		Valid: true,
		},
		OrganizationID: org.ID,
		InvalidateAfterSecs: preset.InvalidateAfterSecs,
		OrganizationID: org.ID,
		})
		}))
		}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4275,6 +4275,21 @@ func (q *FakeQuerier) GetPresetByWorkspaceBuildID(_ context.Context, workspaceBu
		return database.TemplateVersionPreset{}, sql.ErrNoRows
		}

		func (q *FakeQuerier) GetPresetParametersByPresetID(_ context.Context, presetID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()

		parameters := make([]database.TemplateVersionPresetParameter, 0)
		for _, parameter := range q.presetParameters {
		if parameter.TemplateVersionPresetID != presetID {
		continue
		}
		parameters = append(parameters, parameter)
		}

		return parameters, nil
		}

		func (q *FakeQuerier) GetPresetParametersByTemplateVersionID(_ context.Context, templateVersionID uuid.UUID) ([]database.TemplateVersionPresetParameter, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()
Expand All		@@ -4293,7 +4308,6 @@ func (q *FakeQuerier) GetPresetParametersByTemplateVersionID(_ context.Context,
		continue
		}
		parameters = append(parameters, parameter)
		break
		}
		}

Expand DownExpand Up		@@ -8854,6 +8868,11 @@ func (q *FakeQuerier) InsertPreset(_ context.Context, arg database.InsertPresetP
		TemplateVersionID: arg.TemplateVersionID,
		Name: arg.Name,
		CreatedAt: arg.CreatedAt,
		DesiredInstances: arg.DesiredInstances,
		InvalidateAfterSecs: sql.NullInt32{
		Int32: 0,
		Valid: true,
		},
		}
		q.presets = append(q.presets, preset)
		return preset, nil
Expand Down