Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: persist prebuild definitions on template import#16951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 88 commits intomainfromjjs/insert-prebuilds
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
88 commits
Select commitHold shift + click to select a range
5ecc277
add prebuilds system user database changes and associated changes
SasSwartMar 12, 2025
bc5f4f4
optionally prevent system users from counting to user count
dannykoppingMar 13, 2025
48c5372
appease the linter
dannykoppingMar 13, 2025
b16d126
add unit test for system user behaviour
dannykoppingMar 13, 2025
2c25542
reverting RBAC changes; not relevant here
dannykoppingMar 13, 2025
8e491d8
removing unnecessary changes
dannykoppingMar 13, 2025
514fdbf
exclude system user db tests from non-linux OSs
dannykoppingMar 13, 2025
390a1fd
feat: add migrations and queries to support prebuilds
SasSwartMar 12, 2025
07e9613
Merge remote-tracking branch 'origin/main' into prebuilds-db
SasSwartMar 17, 2025
a07c2b2
feat: persist prebuild definitions on template import
SasSwartMar 17, 2025
300e80f
add prebuilds system user database changes and associated changes
SasSwartMar 12, 2025
b788237
optionally prevent system users from counting to user count
dannykoppingMar 13, 2025
8122595
appease the linter
dannykoppingMar 13, 2025
bfb7c28
add unit test for system user behaviour
dannykoppingMar 13, 2025
6639167
reverting RBAC changes; not relevant here
dannykoppingMar 13, 2025
769ae1d
removing unnecessary changes
dannykoppingMar 13, 2025
e7e9c27
exclude system user db tests from non-linux OSs
dannykoppingMar 13, 2025
3936047
Rename prebuild system user reference
SasSwartMar 17, 2025
8bdcafb
ensure that users.IsSystem is not nullable
SasSwartMar 17, 2025
412d198
feat: add migrations and queries to support prebuilds
SasSwartMar 12, 2025
51773ec
Simplify workspace_latest_build view
dannykoppingMar 14, 2025
23773c2
Revert test change
dannykoppingMar 17, 2025
bc3ff44
make gen
dannykoppingMar 17, 2025
baa3076
refactor: add comments to SQL queries
evgeniy-scherbinaMar 19, 2025
ed14fb3
test: added get-presets-backoff test
evgeniy-scherbinaMar 20, 2025
3cc74fb
refactor: add comment to SQL query
evgeniy-scherbinaMar 20, 2025
fc32154
refactor: add comments + improve tests
evgeniy-scherbinaMar 21, 2025
d7b4ec4
fix: bug in SQL
evgeniy-scherbinaMar 21, 2025
e8b53f7
test: minor changes to the test
evgeniy-scherbinaMar 21, 2025
9df6554
refactor: remove job_status from SQL query
evgeniy-scherbinaMar 21, 2025
ccc309e
refactor: embed preset_prebuilds table into presets table
evgeniy-scherbinaMar 21, 2025
ee1f16a
refactor: rename sql table
evgeniy-scherbinaMar 21, 2025
d040ddd
refactor: remove unnecessary JOIN
evgeniy-scherbinaMar 23, 2025
83a6722
refactor: remove unnecessary JOIN
evgeniy-scherbinaMar 23, 2025
cd70710
refactor: use INNER JOIN for consistency
evgeniy-scherbinaMar 23, 2025
0f3bda0
Merge remote-tracking branch 'origin/prebuilds-db' into jjs/insert-pr…
SasSwartMar 24, 2025
a7c7cd2
make lint
SasSwartMar 24, 2025
97cc4ff
refactor: simplify GetPresetsBackoff SQL Query
evgeniy-scherbinaMar 24, 2025
4d59039
Revert "refactor: simplify GetPresetsBackoff SQL Query"
evgeniy-scherbinaMar 24, 2025
205d6af
refactor: improve GetPresetsBackoff query
evgeniy-scherbinaMar 24, 2025
e489e1b
Merge remote-tracking branch 'origin/main' into prebuilds-db
evgeniy-scherbinaMar 25, 2025
1b29686
Merge remote-tracking branch 'origin/main' into prebuilds-db
evgeniy-scherbinaMar 25, 2025
20470e4
fix: bump migration numbers
evgeniy-scherbinaMar 25, 2025
6fc1889
Merge remote-tracking branch 'origin/main' into jjs/insert-prebuilds
SasSwartMar 25, 2025
7b9c8ce
test: remove deprecated test
evgeniy-scherbinaMar 25, 2025
e189a0b
fix: fix linter
evgeniy-scherbinaMar 25, 2025
692c0e5
fix: fix 000310_prebuilds.down migration
evgeniy-scherbinaMar 25, 2025
f747db0
fix: fix fixture migration
evgeniy-scherbinaMar 25, 2025
3166a42
fix: fix get-presets-backoff test
evgeniy-scherbinaMar 25, 2025
aa6b490
fix: fix linter
evgeniy-scherbinaMar 25, 2025
bc4e7d2
fix: fix linter
evgeniy-scherbinaMar 25, 2025
f167b92
correctly select for the latest built with a preset in latest_prebuil…
SasSwartMar 26, 2025
8fd34ab
Merge remote-tracking branch 'origin/main' into prebuilds-db
SasSwartMar 26, 2025
7a8ec49
Properly label and filter metrics for prebuilds
SasSwartMar 26, 2025
a64d661
test: fix db tests
evgeniy-scherbinaMar 27, 2025
865998b
Merge branch 'prebuilds-db' into jjs/insert-prebuilds
SasSwartMar 27, 2025
c787cd2
test: added tests for workspaces with multiple agents
evgeniy-scherbinaMar 27, 2025
bd38603
refactor: avoid code duplication
evgeniy-scherbinaMar 27, 2025
097f9c3
clarify query clause
SasSwartMar 27, 2025
4cfdd6f
tidy up dbauthz_test.go
SasSwartMar 27, 2025
4a34d52
refactor: remove * usage from prebuilds.sql queries
evgeniy-scherbinaMar 27, 2025
8d9cd45
refactor: remove * usage from prebuilds views
evgeniy-scherbinaMar 27, 2025
f870d7e
refactor: join wlb with pj
evgeniy-scherbinaMar 27, 2025
18ad931
refactor: Rename SQL query
evgeniy-scherbinaMar 27, 2025
4667171
Added comments for SQL query
evgeniy-scherbinaMar 27, 2025
a26c094
refactor: fix down migration
evgeniy-scherbinaMar 27, 2025
bf4ab53
make lint
SasSwartMar 28, 2025
a84b1bb
Merge remote-tracking branch 'origin/main' into jjs/insert-prebuilds
SasSwartMar 28, 2025
6ed4121
Merge remote-tracking branch 'origin/main' into prebuilds-db
SasSwartMar 28, 2025
e8b1502
Merge branch 'prebuilds-db' into jjs/insert-prebuilds
SasSwartMar 28, 2025
2312f41
renumber migrations
SasSwartMar 28, 2025
4540a55
add tests for prebuilds in the provisionerdserver
SasSwartMar 28, 2025
5c41ba9
Merge branch 'prebuilds-db' into jjs/insert-prebuilds
SasSwartMar 28, 2025
d09b757
fix indent
SasSwartMar 28, 2025
61e86f6
make more use of dbgen
SasSwartMar 28, 2025
1419df0
update dbmemt
SasSwartMar 28, 2025
6589221
Add tests
SasSwartMar 28, 2025
b15b97a
Merge origin/main
SasSwartApr 3, 2025
dd656a7
Merge remote-tracking branch 'origin/main' into jjs/insert-prebuilds
SasSwartApr 3, 2025
508b244
fix tests
SasSwartApr 3, 2025
e1f585d
remove duplicate migrations fixture
SasSwartApr 3, 2025
7d4f1b9
clean up go.mod slightly
SasSwartApr 3, 2025
43f82b9
update dependency on terraform-provider-coder
SasSwartApr 7, 2025
5d8de71
simplify query
SasSwartApr 7, 2025
a87933a
Correct the prebuilds type
SasSwartApr 7, 2025
798cfa1
fix prebuild decoding
SasSwartApr 7, 2025
dc87f45
make fmt
SasSwartApr 7, 2025
7c17fcd
update our dependency on terraform-provider-coder
SasSwartApr 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Simplify workspace_latest_build view
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
  • Loading branch information
@dannykopping
dannykopping committedMar 17, 2025
commit51773ecaa7a6ce81f3cee93d8bc6005b33e076a4
2 changes: 1 addition & 1 deletioncoderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -362,7 +362,7 @@ var (

subjectPrebuildsOrchestrator = rbac.Subject{
FriendlyName: "Prebuilds Orchestrator",
ID: prebuilds.OwnerID.String(),
ID: prebuilds.SystemUserID.String(),
Roles: rbac.Roles([]rbac.Role{
{
Identifier: rbac.RoleIdentifier{Name: "prebuilds-orchestrator"},
Expand Down
39 changes: 17 additions & 22 deletionscoderd/database/dump.sql
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

76 changes: 29 additions & 47 deletionscoderd/database/migrations/000302_prebuilds.up.sql
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,38 @@
CREATE VIEW workspace_latest_build AS
SELECT wb.*
FROM (SELECT tv.template_id,
wbmax.workspace_id,
MAX(wbmax.build_number) as max_build_number
FROM workspace_builds wbmax
JOIN template_versions tv ON (tv.id = wbmax.template_version_id)
GROUP BY tv.template_id, wbmax.workspace_id) wbmax
JOIN workspace_builds wb ON (
wb.workspace_id = wbmax.workspace_id
AND wb.build_number = wbmax.max_build_number
);
SELECT DISTINCT ON (workspace_id) *
FROM workspace_builds
ORDER BY workspace_id, build_number DESC;

CREATE VIEW workspace_prebuilds AS
WITH
-- All workspaces owned by the "prebuilds" user.
all_prebuilds AS (SELECT w.*
FROM workspaces w
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0'), -- The system user responsible for prebuilds.
-- All workspace agents belonging to the workspaces owned by the "prebuilds" user.
workspace_agents AS (SELECT w.id AS workspace_id, wa.id AS agent_id, wa.lifecycle_state, wa.ready_at
FROM workspaces w
INNER JOIN workspace_latest_build wlb ON wlb.workspace_id = w.id
INNER JOIN workspace_resources wr ON wr.job_id = wlb.job_id
INNER JOIN workspace_agents wa ON wa.resource_id = wr.id
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0' -- The system user responsible for prebuilds.
GROUP BY w.id, wa.id),
-- We can't rely on the template_version_preset_id in the workspace_builds table because this value is only set on the
-- initial workspace creation. Subsequent stop/start transitions will not have a value for template_version_preset_id,
-- and therefore we can't rely on (say) the latest build's chosen template_version_preset_id.
--
-- See https://github.com/coder/internal/issues/398
current_presets AS (SELECT w.id AS prebuild_id, lps.template_version_preset_id
FROM workspaces w
INNER JOIN (
-- The latest workspace build which had a preset explicitly selected
SELECT wb.*
FROM (SELECT tv.template_id,
wbmax.workspace_id,
MAX(wbmax.build_number) as max_build_number
FROM workspace_builds wbmax
JOIN template_versions tv ON (tv.id = wbmax.template_version_id)
WHERE wbmax.template_version_preset_id IS NOT NULL
GROUP BY tv.template_id, wbmax.workspace_id) wbmax
JOIN workspace_builds wb ON (
wb.workspace_id = wbmax.workspace_id
AND wb.build_number = wbmax.max_build_number
)) lps ON lps.workspace_id = w.id
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0') -- The system user responsible for prebuilds.
-- All workspaces owned by the "prebuilds" user.
all_prebuilds AS (SELECT w.*
FROM workspaces w
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0'), -- The system user responsible for prebuilds.
-- We can't rely on the template_version_preset_id in the workspace_builds table because this value is only set on the
-- initial workspace creation. Subsequent stop/start transitions will not have a value for template_version_preset_id,
-- and therefore we can't rely on (say) the latest build's chosen template_version_preset_id.
--
-- See https://github.com/coder/internal/issues/398
latest_prebuild_builds AS (SELECT *
FROM workspace_latest_build
WHERE template_version_preset_id IS NOT NULL),
-- All workspace agents belonging to the workspaces owned by the "prebuilds" user.
workspace_agents AS (SELECT w.id AS workspace_id, wa.id AS agent_id, wa.lifecycle_state, wa.ready_at
FROM workspaces w
INNER JOIN workspace_latest_build wlb ON wlb.workspace_id = w.id
INNER JOIN workspace_resources wr ON wr.job_id = wlb.job_id
INNER JOIN workspace_agents wa ON wa.resource_id = wr.id
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0' -- The system user responsible for prebuilds.
GROUP BY w.id, wa.id),
current_presets AS (SELECT w.id AS prebuild_id, lpb.template_version_preset_id
FROM workspaces w
INNER JOIN latest_prebuild_builds lpb ON lpb.workspace_id = w.id
WHERE w.owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0') -- The system user responsible for prebuilds.
SELECT p.*, a.agent_id, a.lifecycle_state, a.ready_at, cp.template_version_preset_id AS current_preset_id
FROM all_prebuilds p
LEFT JOIN workspace_agents a ON a.workspace_id = p.id
INNER JOIN current_presets cp ON cp.prebuild_id = p.id;
LEFT JOIN workspace_agents a ON a.workspace_id = p.id
INNER JOIN current_presets cp ON cp.prebuild_id = p.id;

CREATE VIEW workspace_prebuild_builds AS
SELECT *
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp