- Notifications
You must be signed in to change notification settings - Fork906
docs: document definition of workspace activity#16941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| for your workspace. | ||
| ### What counts as workspace activity? | ||
| A workspace is considered "active" when Coder detects one or more active sessions with your workspace. Coder specifically tracks these session types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I want to add something like "saving changes to code counts as activity," which I think is true, but it seems like that might be oversimplified. Is there a good single-(noncomplex)-sentence summary we can add here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That would be really nice but as far as I understand our activity tracking is based on network usage and doesn't count file activity.
I am not sure who is the right person to confirm this.
Maybe@deansheather?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@f0ssel I've realized I don't know what state we left things in re: the workspace activity refactor. Can you look at this section and comment whether it's accurate regarding the code as it exists today?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I'd like@f0ssel to double-check the conditions under which we bump the autostop time due to activity. Doesn't have to block the merge, as we can fix it up in a second PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As Spike mentioned, we need to square this with the workspace activity refactor.
But as far as I can tell, the updated documentation corresponds with what wewant to be true.
merging this as-is and we'll come back to it with more edits with the workspace activity refactor |
bbe7dac intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
closes:#16884
aligns the documentation with what users see when they adjust settings and uses thenotion discussion as a reference. This PR reflects current behavior from what I can tell.
preview