Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: use consistent examples in prometheus doc and add namespaceSelector spec#16918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EdwardAngert merged 1 commit intomainfrom15385-prometheus
Mar 14, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedMar 13, 2025•
edited
Loading

closes:#15385

@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelMar 13, 2025
@EdwardAngertEdwardAngert self-assigned thisMar 13, 2025
Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm fine with renaming;prom-http was simply shorter to write but I missed the wider context. Good callout with thenamespaceSelector!

EdwardAngert reacted with rocket emoji
@matifalimatifali removed their request for reviewMarch 13, 2025 20:59
@EdwardAngert
Copy link
ContributorAuthor

@johnstcn 🙌

I'm fine with renaming;prom-http was simply shorter to write but I missed the wider context. Good callout with thenamespaceSelector!

I'm into it - less typing and I'm less likely to typo:shipit:

@EdwardAngertEdwardAngert merged commitcf7d143 intomainMar 14, 2025
34 checks passed
@EdwardAngertEdwardAngert deleted the 15385-prometheus branchMarch 14, 2025 02:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@stirbystirbyAwaiting requested review from stirby

Assignees

@EdwardAngertEdwardAngert

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc Issues Prometheus Integration
2 participants
@EdwardAngert@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp