Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add prebuilds system user#16916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 28 commits intomainfromprebuilds-system-user
Mar 25, 2025
Merged

chore: add prebuilds system user#16916

SasSwart merged 28 commits intomainfromprebuilds-system-user
Mar 25, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedMar 13, 2025
edited by SasSwart
Loading

Pre-requisite for#16891

Closescoder/internal#515

This PR introduces a new concept of a "system" user.

Our data model requires that all workspaces have an owner (ausers relation), and prebuilds is a feature that will spin up workspaces to be claimed later by actual users - and thus needs to own the workspaces in the interim.

Naturally, introducing a change like this touches a few aspects around the codebase and we've taken the approachdefault hidden here; in other words, queries for users will by defaultexclude all system users, but there is a flag to ensure they can be displayed. This keeps the changeset relatively small.

This user has minimal permissions (it's equivalent to amember since it has no roles). It will be associated with the default org in the initial migration, and thereafter we'll need to somehow ensure its membership aligns with templates (which are org-scoped) for which it'll need to provision prebuilds; that's a solution we'll have in a subsequent PR.

@evgeniy-scherbina
Copy link
Contributor

Looks okay to me

SasSwartand others added7 commitsMarch 17, 2025 12:11
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
appeasing linterSigned-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykopping marked this pull request as ready for reviewMarch 17, 2025 12:54
SasSwart added a commit that referenced this pull requestMar 18, 2025
When trying to add [systemusers](#16916), we discovered anissue in two migrations that added values to the login_type enum.After some[consideration](#16916 (comment)),we decided to retroactively correct them.
EdwardAngert pushed a commit that referenced this pull requestMar 18, 2025
When trying to add [systemusers](#16916), we discovered anissue in two migrations that added values to the login_type enum.After some[consideration](#16916 (comment)),we decided to retroactively correct them.
@SasSwartSasSwartenabled auto-merge (squash)March 25, 2025 11:55
@SasSwartSasSwartdisabled auto-mergeMarch 25, 2025 11:57
@SasSwartSasSwartenabled auto-merge (squash)March 25, 2025 12:04
@SasSwartSasSwart merged commit4c33846 intomainMar 25, 2025
34 checks passed
@SasSwartSasSwart deleted the prebuilds-system-user branchMarch 25, 2025 12:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk left review comments

@SasSwartSasSwartSasSwart left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

@evgeniy-scherbinaevgeniy-scherbinaAwaiting requested review from evgeniy-scherbina

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for system users to the database
6 participants
@dannykopping@evgeniy-scherbina@johnstcn@spikecurtis@Emyrk@SasSwart

[8]ページ先頭

©2009-2025 Movatter.jp