- Notifications
You must be signed in to change notification settings - Fork1k
fix: replace both colons and slashes in SBOM filename for Docker image#16915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
matifali merged 1 commit intomainfromthomask33/03-13-fix_replace_both_colons_and_slashes_in_sbom_filename_for_docker_imageMar 13, 2025
Merged
fix: replace both colons and slashes in SBOM filename for Docker image#16915
matifali merged 1 commit intomainfromthomask33/03-13-fix_replace_both_colons_and_slashes_in_sbom_filename_for_docker_imageMar 13, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Change-Id: Ifd7bad6d165393e11202e5bf070a4cb26eaa6a6aSigned-off-by: Thomas Kosiewski <tk@coder.com>
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
matifali approved these changesMar 13, 2025
7171d52 intomain 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes the SBOM filename generation in the Docker build script to properly handle image tags that contain slashes. The current implementation only replaces colons with underscores, but fails when image tags include slashes (common in registry paths).
The fix updates the string replacement to handle both colons and slashes in the image tag when generating the SBOM filename.
Change-Id: Ifd7bad6d165393e11202e5bf070a4cb26eaa6a6a
Signed-off-by: Thomas Kosiewskitk@coder.com