Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: remove broken gfm alert#16902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/broken-gfm-alert
Mar 13, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 13, 2025
edited
Loading

It looks like GFM does not respect the![] alert syntax when it's enclosed within a div. This is true for both the coder.com GFM renderer, and GitHub's (though I assume they're the same internally).

When the section is surrounded by a<div>:
image

When it's not:
image

Presumably same deal on Coder.com:
image

In our case, we really want the tabs, and the alert block is less important, so we'll downgrade it to a regular quote.

cc@aqandrew for visibility, in case you're aware of a workaround. Merging this for now to remove the broken line.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 13, 2025 05:12
@ethanndicksonethanndickson merged commit4994ba1 intomainMar 13, 2025
41 checks passed
@ethanndicksonethanndickson deleted the ethan/broken-gfm-alert branchMarch 13, 2025 05:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 13, 2025
@aqandrew
Copy link

Thanks for this! Unfortunately I don't know of a workaround.

The rehype-github-alert package that we're using only transforms top-level blockquotes; wrapping the blockquote in any non-root parent element will cause an early return:https://github.com/rehypejs/rehype-github/blob/d602dab29fab941943a14b27d801b18f446636ee/packages/alert/lib/index.js#L60-L69

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@aqandrew

[8]ページ先頭

©2009-2025 Movatter.jp