- Notifications
You must be signed in to change notification settings - Fork905
docs: remove broken gfm alert#16902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
4994ba1
intomainUh oh!
There was an error while loading.Please reload this page.
aqandrew commentedMar 14, 2025
Thanks for this! Unfortunately I don't know of a workaround. The rehype-github-alert package that we're using only transforms top-level blockquotes; wrapping the blockquote in any non-root parent element will cause an early return:https://github.com/rehypejs/rehype-github/blob/d602dab29fab941943a14b27d801b18f446636ee/packages/alert/lib/index.js#L60-L69 |
Uh oh!
There was an error while loading.Please reload this page.
It looks like GFM does not respect the
![]
alert syntax when it's enclosed within a div. This is true for both the coder.com GFM renderer, and GitHub's (though I assume they're the same internally).When the section is surrounded by a

<div>
:When it's not:

Presumably same deal on Coder.com:

In our case, we really want the tabs, and the alert block is less important, so we'll downgrade it to a regular quote.
cc@aqandrew for visibility, in case you're aware of a workaround. Merging this for now to remove the broken line.