- Notifications
You must be signed in to change notification settings - Fork1k
fix(agent/agentcontainers): improve testing of convertDockerInspect, return correct host port#16887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
80ac9a3
chore(agent/agentcontainers): refactor runDockerInspect and convertDo…
johnstcn0ecceb0
chore(agent/agentcontainers): add dedicated test for convertDockerIns…
johnstcn55998d0
fix(agent/agentcontainers): fix incorrectly parsed port
johnstcnfb78d33
nolint paralleltest
johnstcna7d1ea4
chore: adjust testdata structure
johnstcn393f6e9
use a []byte instead of a string
johnstcn95b156e
fix(agent/agentcontainers): create new WorkspaceAgentDevcontainerPort…
johnstcnf8f3000
fix(site): correct container port link
johnstcn999469f
chore(site): add stories for AgentDevcontainerCard
johnstcn8338af3
make fmt lint
johnstcn2f0180e
rm extraneous null check
johnstcn1ae6015
address PR comment
johnstcnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
nolint paralleltest
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitfb78d335047225208ee8deccd61cf89c514e70fe
There are no files selected for viewing
2 changes: 2 additions & 0 deletionsagent/agentcontainers/containers_internal_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.