Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(agent/agentcontainers): improve testing of convertDockerInspect, return correct host port#16887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 12 commits intomainfromcj/agentcontainers-port-fix-2
Mar 18, 2025
Merged
Changes from1 commit
Commits
Show all changes
12 commits
Select commitHold shift + click to select a range
80ac9a3
chore(agent/agentcontainers): refactor runDockerInspect and convertDo…
johnstcnMar 11, 2025
0ecceb0
chore(agent/agentcontainers): add dedicated test for convertDockerIns…
johnstcnMar 11, 2025
55998d0
fix(agent/agentcontainers): fix incorrectly parsed port
johnstcnMar 11, 2025
fb78d33
nolint paralleltest
johnstcnMar 12, 2025
a7d1ea4
chore: adjust testdata structure
johnstcnMar 12, 2025
393f6e9
use a []byte instead of a string
johnstcnMar 12, 2025
95b156e
fix(agent/agentcontainers): create new WorkspaceAgentDevcontainerPort…
johnstcnMar 13, 2025
f8f3000
fix(site): correct container port link
johnstcnMar 13, 2025
999469f
chore(site): add stories for AgentDevcontainerCard
johnstcnMar 13, 2025
8338af3
make fmt lint
johnstcnMar 13, 2025
2f0180e
rm extraneous null check
johnstcnMar 18, 2025
1ae6015
address PR comment
johnstcnMar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
rm extraneous null check
  • Loading branch information
@johnstcn
johnstcn committedMar 18, 2025
commit2f0180e58331e09a1ca0929fa69e968ca5a51cad
5 changes: 1 addition & 4 deletionssite/src/modules/resources/AgentDevcontainerCard.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,10 +54,7 @@ export const AgentDevcontainerCard: FC<AgentDevcontainerCardProps> = ({
container.ports.map((port) => {
const portLabel = `${port.port}/${port.network.toUpperCase()}`;
const hasHostBind =
port.host_port !== undefined &&
port.host_port !== null &&
port.host_ip !== undefined &&
port.host_ip !== null;
port.host_port !== undefined && port.host_ip !== undefined;
const helperText = hasHostBind
? `${port.host_ip}:${port.host_port}`
: "Not bound to host";
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp