- Notifications
You must be signed in to change notification settings - Fork1k
fix: updateWorkspacesEmpty.tsx from material ui to tailwind#16886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedMar 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
@brettkolodny can you help review this PR? |
I have read the CLA Document and I hereby sign the CLA |
WorkspacesEmpty.tsx from material ui to tailwindUh oh!
There was an error while loading.Please reload this page.
| backgroundColor:theme.palette.background.paper, | ||
| }, | ||
| })} | ||
| className="w-[320px] p-4 rounded-md border border-divider text-left flex gap-4 no-underline text-inherit hover:bg-paper" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the oldtheme.palette.divider andtheme.palette.background.paper colors haven't been carried over from material ui to tailwind, soborder-divider andhover:bg-paper are not actually valid classes.
if you look at the failing chromatic tests, you can see what it looked like before and what it looks like now. you can see the set of available tailwind colors in our tailwind.config.js file, and their actual values in index.css. the match doesn't have to be exact, but the colors should be close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated the colors to the closest that I could see which was border-surface-grey.
Looking good after those color changed! |
Took another look at the code this morning and saw the colors were a little off and found better matching ones. |
looks good! thank you! |
83f1d82 intocoder:mainUh oh!
There was an error while loading.Please reload this page.
Attached screenshots of code that I updated on WorkspacesEmpty.tsx
