Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: clarify that CODER_EXTERNAL_AUTH_0_ID is used in callback URLs#16879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EdwardAngert merged 6 commits intomainfromfix-external-auth-docs-16851
Apr 1, 2025

Conversation

bpmct
Copy link
Member

@bpmctbpmct commentedMar 11, 2025•
edited by EdwardAngert
Loading

Summary

  • Clarifies that the CODER_EXTERNAL_AUTH_0_ID value is used as part of the OAuth callback URL path
  • Adds explicit callback URL examples to GitLab and Bitbucket Server sections
  • Updates the GitHub OAuth app configuration instructions to be more explicit
  • Fixes the documentation mistake where it claimed this ID was only for "internal reference"

Test plan

  • Documentation change only
  • Verified consistency across all OAuth provider sections

Fixes#16851

preview

🤖 Generated withClaude Code

This commit clarifies that the CODER_EXTERNAL_AUTH_0_ID value is used as part of thecallback URL path when configuring external authentication providers. Thedocumentation previously stated it was only for internal reference, which wasmisleading as it's a critical part of the OAuth provider configuration.Fixes#16851🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@EdwardAngertEdwardAngert self-requested a reviewMarch 18, 2025 01:23
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelMar 18, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks

Co-authored-by: M Atif Ali <atif@coder.com>
@EdwardAngertEdwardAngertenabled auto-merge (squash)March 18, 2025 13:57
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMar 26, 2025
auto-merge was automatically disabledMarch 30, 2025 00:07

Pull request was closed

@EdwardAngert
Copy link
Contributor

this shouldn't havestaled out and I accidentally duplicated it

I'm going to (reopen this and) mix this and the duplicate branch together to grab whatever each is missing

@EdwardAngertEdwardAngert removed the staleThis issue is like stale bread. labelApr 1, 2025
@EdwardAngertEdwardAngert changed the base branch frommain to16875-git-workspace-authApril 1, 2025 20:32
@EdwardAngertEdwardAngert changed the base branch from16875-git-workspace-auth tomainApril 1, 2025 20:34
@EdwardAngert
Copy link
Contributor

I didn't duplicate it - disregard that.

a little more of an update to the examples and then:shipit:

@EdwardAngertEdwardAngert merged commitfd24116 intomainApr 1, 2025
28 checks passed
@EdwardAngertEdwardAngert deleted the fix-external-auth-docs-16851 branchApril 1, 2025 21:03
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EdwardAngertEdwardAngertEdwardAngert approved these changes

@matifalimatifalimatifali approved these changes

@michaelvp411michaelvp411Awaiting requested review from michaelvp411

Assignees

@bpmctbpmct

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch between docs and AUTH_0_ID function
3 participants
@bpmct@EdwardAngert@matifali
[8]ページ先頭
©2009-2025 Movatter.jp