- Notifications
You must be signed in to change notification settings - Fork907
chore: hide workspace creation UI for users without permission#16871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
e695580
chore: hide workspace creation UI for users without permission
jaaydenh1da4473
fix: fix import
jaaydenhb9ec248
fix: update entities
jaaydenhd5033d1
fix: format
jaaydenhff77fe9
chore: hide create workspace button on template header
jaaydenhd77f581
chore: hide workspace creation UI for users without permission
jaaydenh8b159ac
fix: fix import
jaaydenh5e70928
fix: format
jaaydenh8b4be15
chore: cleanup
jaaydenh352b29b
fix: fix test
jaaydenh901825a
chore: updates for PR review
jaaydenh3ecc9d9
fix: update storybook testsw
jaaydenh221750b
Merge branch 'main' into jaaydenh/workspace-creation
jaaydenhFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletionssite/src/api/queries/organizations.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletionssite/src/modules/permissions/workspaces.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
export const workspacePermissionChecks = (organizationId: string) => | ||
({ | ||
createWorkspaceForUser: { | ||
object: { | ||
resource_type: "workspace", | ||
organization_id: organizationId, | ||
owner_id: "*", | ||
}, | ||
action: "create", | ||
}, | ||
}) as const; | ||
export type WorkspacePermissions = Record< | ||
keyof ReturnType<typeof workspacePermissionChecks>, | ||
boolean | ||
>; | ||
export type WorkspacePermissionName = keyof ReturnType< | ||
typeof workspacePermissionChecks | ||
>; |
9 changes: 6 additions & 3 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletionssite/src/pages/CreateWorkspacePage/permissions.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
13 changes: 11 additions & 2 deletionssite/src/pages/TemplatePage/TemplateLayout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletionssite/src/pages/TemplatePage/TemplatePageHeader.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
23 changes: 13 additions & 10 deletionssite/src/pages/TemplatePage/TemplatePageHeader.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletionsite/src/pages/TemplatesPage/TemplatesPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletionssite/src/pages/TemplatesPage/TemplatesPageView.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.