- Notifications
You must be signed in to change notification settings - Fork906
feat: add provisioner jobs into the UI#16867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.stories.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.stories.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...tionSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPage.stories.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
@aslilac I just left open the discussions about testing and injection, but let me know if they are required for approval. I have no strong opinions on that. |
yeah, I feel pretty strongly that escape hatches in the code purely for testing just dilute the value of testing in the first place and make the code harder to understand, especially the |
@aslilac I think it is done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reviewed the last commits to unblock, LGTM 👍
There was one pending request that I was made and Marcin's reviewed to unblock the merge.
564b387
intomainUh oh!
There was an error while loading.Please reload this page.
Related to#15192.