Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add provisioner jobs into the UI#16867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 8 commits intomainfrombq/provisioner-jobs
Mar 14, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Add provisioner jobs back, but as a sub page of the organization settings
  • Add missing storybook tests to the components

Related to#15192.

@BrunoQuaresmaBrunoQuaresma requested review fromaslilac anda teamMarch 10, 2025 17:51
@BrunoQuaresmaBrunoQuaresma self-assigned thisMar 10, 2025
aslilac
aslilac previously requested changesMar 10, 2025
@BrunoQuaresma
Copy link
CollaboratorAuthor

@aslilac I just left open the discussions about testing and injection, but let me know if they are required for approval. I have no strong opinions on that.

@aslilac
Copy link
Member

yeah, I feel pretty strongly that escape hatches in the code purely for testing just dilute the value of testing in the first place and make the code harder to understand, especially theprovisionerJobs query stuff. I feel a little less strongly about the storybook specific prop, but would still prefer that we use aplay function to test that functionality instead.

BrunoQuaresma reacted with thumbs up emoji

@BrunoQuaresma
Copy link
CollaboratorAuthor

@aslilac I think it is done ✅

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reviewed the last commits to unblock, LGTM 👍

@BrunoQuaresmaBrunoQuaresma dismissedaslilac’sstale reviewMarch 14, 2025 11:21

There was one pending request that I was made and Marcin's reviewed to unblock the merge.

@BrunoQuaresmaBrunoQuaresma merged commit564b387 intomainMar 14, 2025
30 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/provisioner-jobs branchMarch 14, 2025 11:22
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@aslilac@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp