Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: use correct permissions for CRUD of custom roles#16854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 2 commits intomainfromjaaydenh/custom-roles-permissions
Mar 10, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedMar 7, 2025•
edited
Loading

resolvescoder/internal#428

The goal of the PR is to start using updateOrgRoles and deleteOrgRoles permissions to gate custom roles functionality

updateOrgRoles: {object: {resource_type: "assign_org_role",organization_id: organizationId,},action: "update",},deleteOrgRoles: {object: {resource_type: "assign_org_role",organization_id: organizationId,},action: "delete",}

@jaaydenhjaaydenh self-assigned thisMar 7, 2025
@jaaydenhjaaydenh requested a review fromaslilacMarch 7, 2025 23:08
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I love it! this is a tremendous bit of permission cleanup, thank you for the help 😄

jaaydenh reacted with heart emoji
@jaaydenhjaaydenh merged commit86b61ef intomainMar 10, 2025
30 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/custom-roles-permissions branchMarch 10, 2025 22:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orgs: User admins should not see UI to edit or create roles in the UI
2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp