Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable SBOM attestation for image builds#16852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intomainfromatif/sbom
Mar 10, 2025
Merged

Conversation

matifali
Copy link
Member

@matifalimatifali commentedMar 7, 2025•
edited
Loading

Important

We also need to enablecontainerd on depot runners.
image

Testing

  • Tested locally with docker buildx build --sbom=true --output type=local,dest=out -f Dockerfile . to verify that an SBOM file is generated.
  • Tested inCI to ensure the image builds without any errors.

Alsoclosescoder/internal#88

@matifalimatifali changed the titlechore: enable SBOM and Containerd Support in Docker Buildschore: enable SBOM andcontainerd support in Docker buildsMar 7, 2025
@matifalimatifaliforce-pushed theatif/sbom branch 5 times, most recently from4a7c230 to76500beCompareMarch 7, 2025 22:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 7, 2025
Added SBOM (Software Bill of Materials) generation during Docker build to enhance traceability. Refer to Docker documentation on SBOM: docs.docker.com/build/metadata/attestations/sbomUpdated Docker build scripts to use BuildKit for provenance and SBOM support: docs.docker.com/build/metadata/attestationsConfigured Docker daemon to support the Containerd snapshotter feature to improve performance: docs.docker.com/engine/storage/containerd
@matifalimatifali reopened thisMar 7, 2025
@codercoder unlocked this conversationMar 7, 2025
@matifalimatifali changed the titlechore: enable SBOM andcontainerd support in Docker builds[DNM] chore: enable SBOM andcontainerd support in Docker buildsMar 7, 2025
Added SBOM (Software Bill of Materials) generation during Docker build to enhance traceability. Refer to Docker documentation on SBOM: docs.docker.com/build/metadata/attestations/sbomUpdated Docker build scripts to use BuildKit for provenance and SBOM support: docs.docker.com/build/metadata/attestationsConfigured Docker daemon to support the Containerd snapshotter feature to improve performance: docs.docker.com/engine/storage/containerd
Added SBOM (Software Bill of Materials) generation during Docker build to enhance traceability. Refer to Docker documentation on SBOM: docs.docker.com/build/metadata/attestations/sbomUpdated Docker build scripts to use BuildKit for provenance and SBOM support: docs.docker.com/build/metadata/attestationsConfigured Docker daemon to support the Containerd snapshotter feature to improve performance: docs.docker.com/engine/storage/containerd
@matifalimatifali changed the title[DNM] chore: enable SBOM andcontainerd support in Docker buildschore: enable SBOM andcontainerd support in Docker buildsMar 8, 2025
@matifalimatifali changed the titlechore: enable SBOM andcontainerd support in Docker buildschore: enable SBOM attestation for image buildsMar 8, 2025
@matifalimatifali marked this pull request as ready for reviewMarch 8, 2025 22:19
Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Doesn't have to be part of this PR, but we might want to addbuild provenance to our release pipeline.

matifali reacted with thumbs up emoji
@matifalimatifali requested a review fromjohnstcnMarch 10, 2025 10:12
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We previously ran into issues with this:

AFAIR it occurred after enabling the containerd store in depot.dev.

If images are being pushed correctly after re-enabling thecontainerd store then this looks OK to me.

@matifali
Copy link
MemberAuthor

If images are being pushed correctly after re-enabling the containerd store, then this looks OK to me.

I have not tested pushing to a registry yet. But only locally.containrd is a requirement for SBOM attestation.

I will try to test by pushing to a registry before merging.

@matifalimatifali merged commit05ebece intomainMar 10, 2025
46 checks passed
@matifalimatifali deleted the atif/sbom branchMarch 10, 2025 19:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 10, 2025
@matifalimatifali restored the atif/sbom branchMarch 10, 2025 19:39
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn left review comments

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provenance attestations for images
3 participants
@matifali@ThomasK33@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp