Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(dogfood): include multiple templates under dogfood/#16846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 16 commits intomainfromcj/ci-multiple-dogfood-templates
Mar 11, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMar 7, 2025•
edited
Loading

We have an alternative dogfood template that has long-since required manual updating. Bringing this under the auspices ofterraform-provider-coderd. This will also make it easier to add more templates underdogfood/ in the future.

As part of this, I moved the existing template underdogfood/coder. I think I got all of the references to it, but there's a non-zero chance I missed something.

  • Renamesdogfood/contents todogfood/coder.
  • Movescoder-envbuilder todogfood/coder-envbuilder.
  • Updatesdogfood/main.tf to pushcoder-envbuilder template.
  • Replaces hard-coded organization IDs withdata.coderd_organization.default.id.

@johnstcnjohnstcn self-assigned thisMar 7, 2025
@johnstcnjohnstcn changed the titlechore(dogfood): have multiple templates under dogfood/chore(dogfood): include multiple templates under dogfood/Mar 7, 2025
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could this just be a single coderd provider terraform file instead atdogfood/main.tf, with the actual template terraform things indogfood/coder anddogfood/coder-envbuilder (nocontents dirs)

Doesn't seem like we get much gain from having them be two separate apply operations since the coderd provider should support multiple templates

ethanndickson, matifali, and johnstcn reacted with thumbs up emoji
@ethanndickson
Copy link
Member

Dean beat me to it! I think this should just be a seperate resource in the same file, instead of two files.

@johnstcnjohnstcnforce-pushed thecj/ci-multiple-dogfood-templates branch fromf81e490 tofbb1271CompareMarch 10, 2025 09:50
@johnstcnjohnstcnforce-pushed thecj/ci-multiple-dogfood-templates branch from148f59c tod49f813CompareMarch 11, 2025 11:40
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Great Work 🚀

johnstcn reacted with heart emoji
@johnstcnjohnstcnforce-pushed thecj/ci-multiple-dogfood-templates branch from800c96b to6f9c950CompareMarch 11, 2025 13:00
@johnstcnjohnstcn merged commit09dd69a intomainMar 11, 2025
36 checks passed
@johnstcnjohnstcn deleted the cj/ci-multiple-dogfood-templates branchMarch 11, 2025 13:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@ThomasK33ThomasK33ThomasK33 approved these changes

@matifalimatifalimatifali approved these changes

@ethanndicksonethanndicksonAwaiting requested review from ethanndickson

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@johnstcn@ethanndickson@ThomasK33@matifali@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp