Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(agent/agentcontainers): correct definition of remoteEnv#16845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/agentcontainers-meta-remoteenv
Mar 7, 2025

Conversation

johnstcn
Copy link
Member

devcontainer.metadata is apparently an array, not an object. Missed this first time round!

    error= get container env info:               github.com/coder/coder/v2/agent/reconnectingpty.(*Server).handleConn                   /home/runner/work/coder/coder/agent/reconnectingpty/server.go:193             - read devcontainer remoteEnv:               github.com/coder/coder/v2/agent/agentcontainers.EnvInfo                   /home/runner/work/coder/coder/agent/agentcontainers/containers_dockercli.go:119             - unmarshal devcontainer.metadata:               github.com/coder/coder/v2/agent/agentcontainers.devcontainerEnv                   /home/runner/work/coder/coder/agent/agentcontainers/containers_dockercli.go:189             - json: cannot unmarshal array into Go value of type struct { RemoteEnv map[string]string "json:\"remoteEnv\"" }

@johnstcnjohnstcn self-assigned thisMar 7, 2025
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This label can contain an array of json snippets that will be automatically merged with devcontainer.json contents (if any) when a container is created.

From:https://containers.dev/implementors/json_reference/

That is how I understand it as well, changes look good. 👍🏻

@johnstcn
Copy link
MemberAuthor

This label can contain an array of json snippets that will be automatically merged with devcontainer.json contents (if any) when a container is created.

From:https://containers.dev/implementors/json_reference/

That is how I understand it as well, changes look good. 👍🏻

TBH I'd like to auto-generate the struct based on the spec. That will give us a nice heads-up if the spec changes on us.

@johnstcnjohnstcn merged commit61246bc intomainMar 7, 2025
32 checks passed
@johnstcnjohnstcn deleted the cj/agentcontainers-meta-remoteenv branchMarch 7, 2025 15:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp