NotificationsYou must be signed in to change notification settings
Fork913
Star10k

fix(agent/agentcontainers): correct definition of remoteEnv#16845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 1 commit intomainfromcj/agentcontainers-meta-remoteenv

Mar 7, 2025

Merged

fix(agent/agentcontainers): correct definition of remoteEnv#16845

johnstcn merged 1 commit intomainfromcj/agentcontainers-meta-remoteenv

Mar 7, 2025

Conversation

Copy link

Member

johnstcn commentedMar 7, 2025

devcontainer.metadata is apparently an array, not an object. Missed this first time round!

    error= get container env info:               github.com/coder/coder/v2/agent/reconnectingpty.(*Server).handleConn                   /home/runner/work/coder/coder/agent/reconnectingpty/server.go:193             - read devcontainer remoteEnv:               github.com/coder/coder/v2/agent/agentcontainers.EnvInfo                   /home/runner/work/coder/coder/agent/agentcontainers/containers_dockercli.go:119             - unmarshal devcontainer.metadata:               github.com/coder/coder/v2/agent/agentcontainers.devcontainerEnv                   /home/runner/work/coder/coder/agent/agentcontainers/containers_dockercli.go:189             - json: cannot unmarshal array into Go value of type struct { RemoteEnv map[string]string "json:\"remoteEnv\"" }

fix(agent/agentcontainers): correct definition of remoteEnv

a9874ab

johnstcn self-assigned this

Mar 7, 2025

johnstcn requested review frommafredri andSasSwart

March 7, 2025 15:31

mafredri approved these changes

Mar 7, 2025

View reviewed changes

Copy link

Member

mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This label can contain an array of json snippets that will be automatically merged with devcontainer.json contents (if any) when a container is created.

From:https://containers.dev/implementors/json_reference/

That is how I understand it as well, changes look good. 👍🏻

Copy link

MemberAuthor

johnstcn commentedMar 7, 2025

This label can contain an array of json snippets that will be automatically merged with devcontainer.json contents (if any) when a container is created.
From:https://containers.dev/implementors/json_reference/
That is how I understand it as well, changes look good. 👍🏻

TBH I'd like to auto-generate the struct based on the spec. That will give us a nice heads-up if the spec changes on us.