Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): preserve table column order#16843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 8 commits intomainfrom16055-column-sorting
Mar 10, 2025
Merged

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedMar 7, 2025•
edited
Loading

Fixes:#16055

This PR modifies table rendering code in CLI to preserve the same order of columns as selected with--column.

@mtojekmtojek self-assigned thisMar 7, 2025
@mtojekmtojek changed the title16055 column sortingfeat(cli): preserve table column orderMar 7, 2025
@mtojekmtojek requested a review frommafredriMarch 7, 2025 13:35
@mtojekmtojek marked this pull request as ready for reviewMarch 7, 2025 13:35
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Elegant solution ❤️, did not think it would be this easy, thanks!

Do we need an explicit test? We already have a bunch of golden files that implicitly test it though so I could go either way.

mtojekand others added3 commitsMarch 10, 2025 12:25
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@mtojek
Copy link
MemberAuthor

Do we need an explicit test? We already have a bunch of golden files that implicitly test it though so I could go either way.

Looking at the number of golden files affected by changes introduced in this PR, I would say we're fine :)

mafredri reacted with thumbs up emoji

@mtojekmtojekenabled auto-merge (squash)March 10, 2025 12:15
@mtojekmtojek merged commit4b1da9b intomainMar 10, 2025
32 checks passed
@mtojekmtojek deleted the 16055-column-sorting branchMarch 10, 2025 12:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add column ordering support to cliui table
2 participants
@mtojek@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp