- Notifications
You must be signed in to change notification settings - Fork1k
refactor: Update create workspace flow to allow creation from the workspaces page#1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| return( | ||
| <divclassName={styles.footer}> | ||
| <ButtonclassName={styles.button}onClick={onCancel}variant="outlined"> | ||
| <Buttontype="button"className={styles.button}onClick={onCancel}variant="outlined"> |
greyscaledMay 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Question(blocking): Why istype="button" needed here -- is it causing accidental submit ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
By default, any button inside a form submits the form. I thought MUI would add the type="button" automatically but it does not so I have to explicitly say type="button".
Uh oh!
There was an error while loading.Please reload this page.
Related to#1638
PS: This is only about the flow, a major "redesign" will come in a next PR.