Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: hide deleted users from org members query#16830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 2 commits intomainfromlilac/filter-deleted-members
Mar 6, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedMar 6, 2025
edited
Loading

Currently if you delete a user, you see a ghost of them as an organization member, because the query for listing organization members does not filter out deleted users, and the membership doesn't get deleted because users only get soft deleted. This shouldn't be a security issue, because the affected deleted user is still unable to login or take any actions.

I've updated the query to hide deleted users. In the future we may wish to remove these "dangling" records, or mark them as soft deleted as well.

@stirby
Copy link
Collaborator

/cherry-pick release/2.20

@aslilacaslilac merged commiteddccbc intomainMar 6, 2025
32 checks passed
@aslilacaslilac deleted the lilac/filter-deleted-members branchMarch 6, 2025 18:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@stirby@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp