- Notifications
You must be signed in to change notification settings - Fork927
chore: fix regex bug in migration number fixer#16822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
804d826
to0a5d131
CompareUh oh!
There was an error while loading.Please reload this page.
fcb516a
to1208852
CompareSigned-off-by: Danny Kopping <dannykopping@gmail.com>
main
1208852
to14f0f98
Compare
mafredri left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I checked both the grep on macOS (2.6.0-FreeBSD) as well as GNU grep (3.11) and I can't figure out why this would produce different results on any version of grep. The only difference I see here is that we now allow::
and//
, etc.
Or are you suggesting that a remote may be namedEdit: I re-read your description and that was indeed what you were going for. I thought ^this is an illegal format on GitHub but if not, have at it 👍🏻github.com:/coder/coder
and you wanted to add support for that?
Approving to unblock though since it's not a harmful change.
b16275b
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This fixes a slight regex bug on Bash 5, where
[:/]
would only match:
but not both:/
.The former will actually cause the whole script to bork because of
pipefail
, sincegrep
exits 1.