Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: fix regex bug in migration number fixer#16822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intomainfromdk/migration-merge
Mar 6, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedMar 6, 2025
edited
Loading

This fixes a slight regex bug on Bash 5, where[:/] would only match: but not both:/.

$ git remote -v| grep"github.com[:/]coder/coder.*(fetch)"| cut -f1$ git remote -v| grep"github.com[:/]*coder/coder.*(fetch)"| cut -f1origin

The former will actually cause the whole script to bork because ofpipefail, sincegrep exits 1.

@dannykoppingdannykopping marked this pull request as draftMarch 6, 2025 07:01
@dannykoppingdannykoppingforce-pushed thedk/migration-merge branch 2 times, most recently fromfcb516a to1208852CompareMarch 6, 2025 07:03
@dannykoppingdannykopping marked this pull request as ready for reviewMarch 6, 2025 07:06
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykopping changed the titlechore: prevent duplicate migration numbers inmainchore: fix regex bug in migration number fixerMar 6, 2025
Copy link
Member

@mafredrimafredri left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I checked both the grep on macOS (2.6.0-FreeBSD) as well as GNU grep (3.11) and I can't figure out why this would produce different results on any version of grep. The only difference I see here is that we now allow:: and//, etc.

Or are you suggesting that a remote may be namedgithub.com:/coder/coder and you wanted to add support for that?Edit: I re-read your description and that was indeed what you were going for. I thought ^this is an illegal format on GitHub but if not, have at it 👍🏻

Approving to unblock though since it's not a harmful change.

dannykopping reacted with rocket emoji
@dannykoppingdannykopping merged commitb16275b intomainMar 6, 2025
32 checks passed
@dannykoppingdannykopping deleted the dk/migration-merge branchMarch 6, 2025 10:21
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dannykopping@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp