- Notifications
You must be signed in to change notification settings - Fork928
chore: remove unused code#16815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚢
deb95f9 intomainUh oh!
There was an error while loading.Please reload this page.
| /** | ||
| * @file A global error boundary designed to work with React Router. | ||
| * | ||
| * This is not documented well, but because of React Router works, it will | ||
| * automatically intercept any render errors produced in routes, and will | ||
| * "swallow" them, preventing the errors from bubbling up to any error | ||
| * boundaries above the router. The global error boundary must be explicitly | ||
| * bound to a route to work as expected. | ||
| */ |
ParkreinerMar 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@aslilac@brettkolodny Why was this comment deleted?
Up until 2 months ago, we had a broken error boundary for over a year, because the setup doesn't follow standard React and isn't as obvious as it could be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@aslilac will have to give a definitive answer on this. I mistakenly assumed that the comment was related to the import below it that was deleted which is my bad for not reading it fully.
Remove unused variables and imports from several files