Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for workspace app audit#16801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 40 commits intomainfrommafredri/app-audit
Mar 18, 2025
Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedMar 4, 2025•
edited
Loading

This change adds support for workspace app auditing.

To avoid audit log spam, we introduce the concept of app audit sessions. An audit session is unique per workspace app, user, ip, user agent and http status code. The sessions are stored in a separate table from audit logs to allow use-case specific optimizations. Sessions are ephemeral and the table does not function as a log.

The logic for auditing is placed in the DBTokenProvider for workspace apps so that wsproxies are included.

This is the final change affecting the API fo#15139.

Updates#15139

image

johnstcn reacted with thumbs up emojineo-sx5 reacted with thumbs down emoji
@mafredrimafredriforce-pushed themafredri/app-audit branch 9 times, most recently frome94f72d to054a301CompareMarch 5, 2025 22:38
@mafredri
Copy link
MemberAuthor

I've implemented the requested changes, PTAL. Up-to-date view of audit log:

image

We still don't have any custom handling for terminal entry and port forward entry, they will just say "opened the agent".

mtojek reacted with heart emoji

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have any further comments! Thanks for working on this@mafredri !

mafredri reacted with heart emoji
Comment on lines +285 to +292
switch {
case alog.AuditLog.StatusCode == int32(http.StatusSeeOther):
_, _ = b.WriteString("was redirected attempting to ")
_, _ = b.WriteString(string(alog.AuditLog.Action))
case alog.AuditLog.StatusCode >= 400:
_, _ = b.WriteString("unsuccessfully attempted to ")
_, _ = b.WriteString(string(alog.AuditLog.Action))
} else {
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@mafredrimafredri merged commitde41bd6 intomainMar 18, 2025
32 checks passed
@mafredrimafredri deleted the mafredri/app-audit branchMarch 18, 2025 11:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp