NotificationsYou must be signed in to change notification settings
Fork913
Star10.1k

ci: avoid cancelling other nightly-gauntlet jobs on failure#16795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dannykopping merged 1 commit intomainfromethan/nightly-fail-fast

Mar 4, 2025

Merged

ci: avoid cancelling other nightly-gauntlet jobs on failure#16795

dannykopping merged 1 commit intomainfromethan/nightly-fail-fast

Mar 4, 2025

Conversation

Copy link

Member

ethanndickson commentedMar 4, 2025•
edited
Loading

I saw in a failing nightly-gauntlet that the macOS+Postgres tests failing caused the Windows tests to get cancelled:https://github.com/coder/coder/actions/runs/13645971060

There's no harm in letting the other test run, and will let us catch additional flakes & failures. If one job fails, the whole matrix will still fail (once the remaining tests in the matrix have completed) and the slack notification will still be sent.
We previously made this change on our on-pushci workflow.

Relevant documentation:

jobs.<job_id>.strategy.fail-fast applies to the entire matrix. If jobs.<job_id>.strategy.fail-fast is set to true or its expression evaluates to true, GitHub will cancel all in-progress and queued jobs in the matrix if any job in the matrix fails. This property defaults to true.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast